RE: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-23 Thread Weiny, Ira
> > On 7/22/19 4:08 AM, Matthew Wilcox wrote: > > On Sun, Jul 21, 2019 at 10:13:45PM -0700, Ira Weiny wrote: > >> On Sun, Jul 21, 2019 at 09:02:04AM -0700, Matthew Wilcox wrote: > >>> On Fri, Jul 19, 2019 at 12:29:53PM -0700, Ralph Campbell wrote: > Struct page for ZONE_DEVICE private pages u

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-23 Thread Ralph Campbell
On 7/22/19 4:08 AM, Matthew Wilcox wrote: On Sun, Jul 21, 2019 at 10:13:45PM -0700, Ira Weiny wrote: On Sun, Jul 21, 2019 at 09:02:04AM -0700, Matthew Wilcox wrote: On Fri, Jul 19, 2019 at 12:29:53PM -0700, Ralph Campbell wrote: Struct page for ZONE_DEVICE private pages uses the page->mappin

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-22 Thread Matthew Wilcox
On Sun, Jul 21, 2019 at 10:13:45PM -0700, Ira Weiny wrote: > On Sun, Jul 21, 2019 at 09:02:04AM -0700, Matthew Wilcox wrote: > > On Fri, Jul 19, 2019 at 12:29:53PM -0700, Ralph Campbell wrote: > > > Struct page for ZONE_DEVICE private pages uses the page->mapping and > > > and page->index fields wh

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-22 Thread Christoph Hellwig
Looks good modulo any potential kerneldoc issues for which I'm not the expert: Reviewed-by: Christoph Hellwig

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-22 Thread Christoph Hellwig
On Sun, Jul 21, 2019 at 09:02:04AM -0700, Matthew Wilcox wrote: > On Fri, Jul 19, 2019 at 12:29:53PM -0700, Ralph Campbell wrote: > > Struct page for ZONE_DEVICE private pages uses the page->mapping and > > and page->index fields while the source anonymous pages are migrated to > > device private m

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-21 Thread Ira Weiny
On Sun, Jul 21, 2019 at 09:02:04AM -0700, Matthew Wilcox wrote: > On Fri, Jul 19, 2019 at 12:29:53PM -0700, Ralph Campbell wrote: > > Struct page for ZONE_DEVICE private pages uses the page->mapping and > > and page->index fields while the source anonymous pages are migrated to > > device private m

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-21 Thread Matthew Wilcox
On Fri, Jul 19, 2019 at 12:29:53PM -0700, Ralph Campbell wrote: > Struct page for ZONE_DEVICE private pages uses the page->mapping and > and page->index fields while the source anonymous pages are migrated to > device private memory. This is so rmap_walk() can find the page when > migrating the ZON

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-21 Thread Randy Dunlap
Hi, On 7/19/19 12:29 PM, Ralph Campbell wrote: > Struct page for ZONE_DEVICE private pages uses the page->mapping and > and page->index fields while the source anonymous pages are migrated to > device private memory. This is so rmap_walk() can find the page when > migrating the ZONE_DEVICE private

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-19 Thread John Hubbard
On 7/19/19 12:29 PM, Ralph Campbell wrote: > Struct page for ZONE_DEVICE private pages uses the page->mapping and > and page->index fields while the source anonymous pages are migrated to > device private memory. This is so rmap_walk() can find the page when > migrating the ZONE_DEVICE private page

[PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-19 Thread Ralph Campbell
Struct page for ZONE_DEVICE private pages uses the page->mapping and and page->index fields while the source anonymous pages are migrated to device private memory. This is so rmap_walk() can find the page when migrating the ZONE_DEVICE private page back to system memory. ZONE_DEVICE pmem backed fsd