Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style

2015-03-09 Thread yakir
On 2015年03月09日 15:05, Daniel Kurtz wrote: On Mon, Mar 9, 2015 at 12:42 PM, Yakir Yang wrote: - const struct dw_hdmi_mpll_config *mpll_config = -hdmi->plat_data->mpll_cfg; - const struct dw_hdmi_curr_ctrl *curr_ctrl = hdmi->plat_data->cur_ctr; - const str

Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style

2015-03-09 Thread yakir
On 2015年03月09日 14:48, Joe Perches wrote: On Sun, 2015-03-08 at 21:48 -0700, Joe Perches wrote: Shouldn't all of these be static? Don't mind me. These shouldn't be static. I was a bit mislead by the commit message. I think it'd be better not to put patch-like + and - lines in the commit des

Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style

2015-03-09 Thread Daniel Kurtz
On Mon, Mar 9, 2015 at 12:42 PM, Yakir Yang wrote: > - const struct dw_hdmi_mpll_config *mpll_config = > -hdmi->plat_data->mpll_cfg; > - const struct dw_hdmi_curr_ctrl *curr_ctrl = hdmi->plat_data->cur_ctr; > - const struct dw_hdmi_sym_term *sym_term = hdmi

Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style

2015-03-08 Thread Joe Perches
On Sun, 2015-03-08 at 21:48 -0700, Joe Perches wrote: > Shouldn't all of these be static? Don't mind me. These shouldn't be static. I was a bit mislead by the commit message. I think it'd be better not to put patch-like + and - lines in the commit description. cheers, Joe -- To unsubscribe f

Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style

2015-03-08 Thread Joe Perches
On Mon, 2015-03-09 at 12:42 +0800, Yakir Yang wrote: > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c > b/drivers/gpu/drm/bridge/dw_hdmi.c [] > @@ -900,10 +900,10 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, > unsigned char prep, > { > unsigned res_idx, i; > u8 val, msec; >

[PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style

2015-03-08 Thread Yakir Yang
- const struct dw_hdmi_mpll_config *mpll_config = -hdmi->plat_data->mpll_cfg; - const struct dw_hdmi_curr_ctrl *curr_ctrl = hdmi->plat_data->cur_ctr; - const struct dw_hdmi_sym_term *sym_term = hdmi->plat_data->sym_term; + const struct dw_hdmi_plat_data *pl