Re: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data

2018-03-15 Thread Andrey Smirnov
On Thu, Mar 15, 2018 at 6:52 AM, Shawn Guo wrote: > On Thu, Mar 15, 2018 at 06:00:06AM -0700, Andrey Smirnov wrote: >> I am slightly confused by your phrasing. Are you: >> >> a) saying that you dropped my patches in favor of your own that use >> platform_device_add_data() >> >> or >> >> b) asking

Re: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data

2018-03-15 Thread Shawn Guo
On Thu, Mar 15, 2018 at 06:00:06AM -0700, Andrey Smirnov wrote: > I am slightly confused by your phrasing. Are you: > > a) saying that you dropped my patches in favor of your own that use > platform_device_add_data() > > or > > b) asking me to convert my patches to use platform_device_add_data()

Re: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data

2018-03-15 Thread Andrey Smirnov
On Wed, Mar 14, 2018 at 8:08 PM, Shawn Guo wrote: > On Thu, Feb 08, 2018 at 02:47:10PM +0800, Shawn Guo wrote: >> On Mon, Jan 22, 2018 at 07:07:47AM -0800, Andrey Smirnov wrote: >> > Platform device core assumes the ownership of dev.platform_data as >> > well as that it is dynamically allocated an

Re: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data

2018-03-14 Thread Shawn Guo
On Thu, Feb 08, 2018 at 02:47:10PM +0800, Shawn Guo wrote: > On Mon, Jan 22, 2018 at 07:07:47AM -0800, Andrey Smirnov wrote: > > Platform device core assumes the ownership of dev.platform_data as > > well as that it is dynamically allocated and it will try to kfree it > > as a part of platform_devi

Re: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data

2018-02-07 Thread Shawn Guo
On Mon, Jan 22, 2018 at 07:07:47AM -0800, Andrey Smirnov wrote: > Platform device core assumes the ownership of dev.platform_data as > well as that it is dynamically allocated and it will try to kfree it > as a part of platform_device_release(). Change the code to pass > kzalloc'ed chunk of memory

[PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data

2018-01-22 Thread Andrey Smirnov
Platform device core assumes the ownership of dev.platform_data as well as that it is dynamically allocated and it will try to kfree it as a part of platform_device_release(). Change the code to pass kzalloc'ed chunk of memory instead of a pointer to a static memory to avoid causing a BUG() when ca