Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-02 Thread Steven Rostedt
On Wed, 2 Dec 2015 10:23:39 + Russell King - ARM Linux wrote: > On Tue, Dec 01, 2015 at 06:16:43PM +, Russell King - ARM Linux wrote: > > On Tue, Dec 01, 2015 at 12:22:12PM -0500, Steven Rostedt wrote: > > > I guess another solution is to do a copy instead of modifying in place > > > if

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-02 Thread Russell King - ARM Linux
On Tue, Dec 01, 2015 at 06:16:43PM +, Russell King - ARM Linux wrote: > On Tue, Dec 01, 2015 at 12:22:12PM -0500, Steven Rostedt wrote: > > I guess another solution is to do a copy instead of modifying in place > > if it detects the multiple hard link? > > That would be the "transparent" solut

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-01 Thread Michal Marek
Dne 1.12.2015 v 19:16 Russell King - ARM Linux napsal(a): > On Tue, Dec 01, 2015 at 12:22:12PM -0500, Steven Rostedt wrote: >> I guess another solution is to do a copy instead of modifying in place >> if it detects the multiple hard link? > > That would be the "transparent" solution. If you think

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-01 Thread Russell King - ARM Linux
On Tue, Dec 01, 2015 at 12:22:12PM -0500, Steven Rostedt wrote: > On Tue, 1 Dec 2015 17:10:14 + > Russell King - ARM Linux wrote: > > > Another suggestion - maybe recordmcount, which fstat()s the file, > > should check the st_nlink before modifying the file, and error out > > with a helpful e

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-01 Thread Steven Rostedt
On Tue, 1 Dec 2015 17:10:14 + Russell King - ARM Linux wrote: > Another suggestion - maybe recordmcount, which fstat()s the file, > should check the st_nlink before modifying the file, and error out > with a helpful error message telling people not to use hardlinks, > which would stop nasty s

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-01 Thread Russell King - ARM Linux
On Tue, Dec 01, 2015 at 11:49:29AM -0500, Steven Rostedt wrote: > On Tue, 1 Dec 2015 16:19:44 + > Russell King - ARM Linux wrote: > > > They hardly "do nothing", as the (eg) recordmcount plasters the build > > log with warnings. A solution to that would be to make recordmcount > > silent if

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-01 Thread Steven Rostedt
On Tue, 1 Dec 2015 16:19:44 + Russell King - ARM Linux wrote: > They hardly "do nothing", as the (eg) recordmcount plasters the build > log with warnings. A solution to that would be to make recordmcount > silent if the section is already present. Note, that warning found plenty of bugs wh

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-01 Thread Michal Marek
On 2015-12-01 17:19, Russell King - ARM Linux wrote: > On Tue, Dec 01, 2015 at 05:07:05PM +0100, Michal Marek wrote: >> So, both recordmcount and the new recordudiv program are idempotent. >> They check if the to-be-added section is already present and do nothing. > > They hardly "do nothing", as

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-01 Thread Russell King - ARM Linux
On Tue, Dec 01, 2015 at 05:07:05PM +0100, Michal Marek wrote: > On 2015-11-30 16:40, Michal Marek wrote: > > On 2015-11-30 16:32, Russell King - ARM Linux wrote: > >> On Mon, Nov 30, 2015 at 04:11:16PM +0100, Michal Marek wrote: > >>> On 2015-11-26 00:47, Russell King - ARM Linux wrote: > Do w

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-12-01 Thread Michal Marek
On 2015-11-30 16:40, Michal Marek wrote: > On 2015-11-30 16:32, Russell King - ARM Linux wrote: >> On Mon, Nov 30, 2015 at 04:11:16PM +0100, Michal Marek wrote: >>> On 2015-11-26 00:47, Russell King - ARM Linux wrote: Do we have any resolution on these programs which modify the object fil

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-11-30 Thread Michal Marek
On 2015-11-30 16:32, Russell King - ARM Linux wrote: > On Mon, Nov 30, 2015 at 04:11:16PM +0100, Michal Marek wrote: >> On 2015-11-26 00:47, Russell King - ARM Linux wrote: >>> On Wed, Nov 25, 2015 at 01:51:03PM -0800, Stephen Boyd wrote: The ARM compiler inserts calls to __aeabi_uidiv() and >

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-11-30 Thread Russell King - ARM Linux
On Mon, Nov 30, 2015 at 04:11:16PM +0100, Michal Marek wrote: > On 2015-11-26 00:47, Russell King - ARM Linux wrote: > > On Wed, Nov 25, 2015 at 01:51:03PM -0800, Stephen Boyd wrote: > >> The ARM compiler inserts calls to __aeabi_uidiv() and > >> __aeabi_idiv() when it needs to perform division on

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-11-30 Thread Michal Marek
On 2015-11-26 00:47, Russell King - ARM Linux wrote: > On Wed, Nov 25, 2015 at 01:51:03PM -0800, Stephen Boyd wrote: >> The ARM compiler inserts calls to __aeabi_uidiv() and >> __aeabi_idiv() when it needs to perform division on signed and >> unsigned integers. If a processor has support for the ud

Re: [PATCH v2 1/2] scripts: Add a recorduidiv program

2015-11-25 Thread Russell King - ARM Linux
On Wed, Nov 25, 2015 at 01:51:03PM -0800, Stephen Boyd wrote: > The ARM compiler inserts calls to __aeabi_uidiv() and > __aeabi_idiv() when it needs to perform division on signed and > unsigned integers. If a processor has support for the udiv and > sdiv division instructions the calls to these sup

[PATCH v2 1/2] scripts: Add a recorduidiv program

2015-11-25 Thread Stephen Boyd
The ARM compiler inserts calls to __aeabi_uidiv() and __aeabi_idiv() when it needs to perform division on signed and unsigned integers. If a processor has support for the udiv and sdiv division instructions the calls to these support routines can be replaced with those instructions. Therefore, reco