Re: [PATCH v2 1/2] media: ir-kbd-i2c: convert to i2c_new_dummy_device()

2019-08-03 Thread Sean Young
On Sat, Aug 03, 2019 at 01:17:49PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 30 Jul 2019 19:55:54 +0200 > Wolfram Sang escreveu: > > > Convert this driver to use the new i2c_new_dummy_device() call and bail > > out if the dummy device cannot be registered to make failure more > > visible to t

Re: [PATCH v2 1/2] media: ir-kbd-i2c: convert to i2c_new_dummy_device()

2019-08-03 Thread Mauro Carvalho Chehab
Em Tue, 30 Jul 2019 19:55:54 +0200 Wolfram Sang escreveu: > Convert this driver to use the new i2c_new_dummy_device() call and bail > out if the dummy device cannot be registered to make failure more > visible to the user. > Please don't do that. At first glance, devm_* sounds a good idea, but

[PATCH v2 1/2] media: ir-kbd-i2c: convert to i2c_new_dummy_device()

2019-07-30 Thread Wolfram Sang
Convert this driver to use the new i2c_new_dummy_device() call and bail out if the dummy device cannot be registered to make failure more visible to the user. Signed-off-by: Wolfram Sang --- Change since v1: * reworded commit message because there was no NULL ptr access drivers/media/i2c/ir-k