Re: [PATCH v2 1/2] leds: core: Introduce LED pattern trigger

2018-08-04 Thread Baolin Wang
Hi Jacek, On 3 August 2018 at 19:59, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/03/2018 10:05 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 3 August 2018 at 05:21, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> Thank you for addressing review remarks. >>> >>> I've played a bit with the in

Re: [PATCH v2 1/2] leds: core: Introduce LED pattern trigger

2018-08-03 Thread Jacek Anaszewski
Hi Baolin, On 08/03/2018 10:05 AM, Baolin Wang wrote: > Hi Jacek, > > On 3 August 2018 at 05:21, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> Thank you for addressing review remarks. >> >> I've played a bit with the interface and I have one conclusion >> regarding pattern parsing, please refer

Re: [PATCH v2 1/2] leds: core: Introduce LED pattern trigger

2018-08-03 Thread Baolin Wang
Hi Jacek, On 3 August 2018 at 05:21, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for addressing review remarks. > > I've played a bit with the interface and I have one conclusion > regarding pattern parsing, please refer below. > > Also one tiny optimization request in pattern_trig_activat

Re: [PATCH v2 1/2] leds: core: Introduce LED pattern trigger

2018-08-02 Thread Bjorn Andersson
On Thu 02 Aug 14:21 PDT 2018, Jacek Anaszewski wrote: > On 08/01/2018 11:01 AM, Baolin Wang wrote: [..] > > diff --git a/drivers/leds/trigger/ledtrig-pattern.c > > b/drivers/leds/trigger/ledtrig-pattern.c [..] > > +static ssize_t pattern_trig_store_pattern(struct device *dev, > > +

Re: [PATCH v2 1/2] leds: core: Introduce LED pattern trigger

2018-08-02 Thread Jacek Anaszewski
Hi Baolin, Thank you for addressing review remarks. I've played a bit with the interface and I have one conclusion regarding pattern parsing, please refer below. Also one tiny optimization request in pattern_trig_activate(). On 08/01/2018 11:01 AM, Baolin Wang wrote: > Some LED controllers have

[PATCH v2 1/2] leds: core: Introduce LED pattern trigger

2018-08-01 Thread Baolin Wang
Some LED controllers have support for autonomously controlling brightness over time, according to some preprogrammed pattern or function. This patch adds pattern trigger that LED device can configure the pattern and trigger it. Signed-off-by: Raphael Teysseyre Signed-off-by: Baolin Wang --- Cha