Re: [PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-12-05 Thread Jonathan Cameron
On 30/11/15 12:16, Peter Meerwald-Stadler wrote: > >> in SOFTWARE buffer mode, a kthread will capture the active scan_elements >> into a kfifo, then compute the remaining time until the next capture tick >> and do an active wait (udelay). > > some minor comments below other than the points Peter

Re: [PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-12-02 Thread Guenter Roeck
On 12/02/2015 09:09 AM, Marc Titinger wrote: On 02/12/2015 17:44, Guenter Roeck wrote: On 12/02/2015 08:20 AM, Marc Titinger wrote: On 02/12/2015 17:04, Guenter Roeck wrote: On 12/02/2015 02:20 AM, Marc Titinger wrote: On 02/12/2015 03:14, Guenter Roeck wrote: On Mon, Nov 30, 2015 at 12:49:1

Re: [PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-12-02 Thread Marc Titinger
On 02/12/2015 17:44, Guenter Roeck wrote: On 12/02/2015 08:20 AM, Marc Titinger wrote: On 02/12/2015 17:04, Guenter Roeck wrote: On 12/02/2015 02:20 AM, Marc Titinger wrote: On 02/12/2015 03:14, Guenter Roeck wrote: On Mon, Nov 30, 2015 at 12:49:14PM +0100, Marc Titinger wrote: in SOFTWARE b

Re: [PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-12-02 Thread Guenter Roeck
On 12/02/2015 08:20 AM, Marc Titinger wrote: On 02/12/2015 17:04, Guenter Roeck wrote: On 12/02/2015 02:20 AM, Marc Titinger wrote: On 02/12/2015 03:14, Guenter Roeck wrote: On Mon, Nov 30, 2015 at 12:49:14PM +0100, Marc Titinger wrote: in SOFTWARE buffer mode, a kthread will capture the acti

Re: [PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-12-02 Thread Marc Titinger
On 02/12/2015 17:04, Guenter Roeck wrote: On 12/02/2015 02:20 AM, Marc Titinger wrote: On 02/12/2015 03:14, Guenter Roeck wrote: On Mon, Nov 30, 2015 at 12:49:14PM +0100, Marc Titinger wrote: in SOFTWARE buffer mode, a kthread will capture the active scan_elements into a kfifo, then compute th

Re: [PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-12-02 Thread Guenter Roeck
On 12/02/2015 02:20 AM, Marc Titinger wrote: On 02/12/2015 03:14, Guenter Roeck wrote: On Mon, Nov 30, 2015 at 12:49:14PM +0100, Marc Titinger wrote: in SOFTWARE buffer mode, a kthread will capture the active scan_elements into a kfifo, then compute the remaining time until the next capture tic

Re: [PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-12-02 Thread Marc Titinger
On 02/12/2015 03:14, Guenter Roeck wrote: On Mon, Nov 30, 2015 at 12:49:14PM +0100, Marc Titinger wrote: in SOFTWARE buffer mode, a kthread will capture the active scan_elements into a kfifo, then compute the remaining time until the next capture tick and do an active wait (udelay). This will p

Re: [PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-12-01 Thread Guenter Roeck
On Mon, Nov 30, 2015 at 12:49:14PM +0100, Marc Titinger wrote: > in SOFTWARE buffer mode, a kthread will capture the active scan_elements > into a kfifo, then compute the remaining time until the next capture tick > and do an active wait (udelay). > > This will produce a stream of up to fours chan

Re: [PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-11-30 Thread Peter Meerwald-Stadler
> in SOFTWARE buffer mode, a kthread will capture the active scan_elements > into a kfifo, then compute the remaining time until the next capture tick > and do an active wait (udelay). some minor comments below > This will produce a stream of up to fours channels plus a 64bits > timestamps (ns)

[PATCH v2 1/2] iio: ina2xx: add support for TI INA2xx Power Monitors

2015-11-30 Thread Marc Titinger
in SOFTWARE buffer mode, a kthread will capture the active scan_elements into a kfifo, then compute the remaining time until the next capture tick and do an active wait (udelay). This will produce a stream of up to fours channels plus a 64bits timestamps (ns). Tested with ina226, on BeagleBoneBla