Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-03 Thread Manish Badarkhe
Hi Pramod >>> @@ -715,10 +724,13 @@ static int bam_resume(struct dma_chan *chan) >>> struct bam_device *bdev = bchan->bdev; >>> unsigned long flag; >>> >>> + pm_runtime_get_sync(bdev->dev); >>> spin_lock_irqsave(&bchan->vc.lock, flag); >>> writel_relaxed(0, ba

Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-03 Thread Pramod Gurav
Hi Manish, Thanks for review. On 3 May 2016 at 15:21, Manish Badarkhe wrote: > Hi Pramod > >> @@ -715,10 +724,13 @@ static int bam_resume(struct dma_chan *chan) >> struct bam_device *bdev = bchan->bdev; >> unsigned long flag; >> >> + pm_runtime_get_sync(bdev->dev); >>

Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-03 Thread Manish Badarkhe
Hi Pramod > @@ -715,10 +724,13 @@ static int bam_resume(struct dma_chan *chan) > struct bam_device *bdev = bchan->bdev; > unsigned long flag; > > + pm_runtime_get_sync(bdev->dev); > spin_lock_irqsave(&bchan->vc.lock, flag); > writel_relaxed(0, bam_addr(bdev, b

[PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-03 Thread Pramod Gurav
Adds pm_runtime support for BAM DMA so that clock is enabled only when there is a transaction going on to help save power. Signed-off-by: Pramod Gurav --- Changes since v1: - Removed unnecessary extra line additions and remavals drivers/dma/qcom/bam_dma.c | 86 ++