Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events

2016-03-07 Thread Ian Munsie
Excerpts from Matt Ochs's message of 2016-03-08 11:26:55 +1100: > Any reason for adding these extra lines as part of this commit? mpe asked for some newlines here in the v1 submission, and it only really made sense to do so if all the related sections had consistent whitespace as well. > > +/* >

Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events

2016-03-07 Thread Matt Ochs
A couple of minor nits below... > On Mar 7, 2016, at 12:59 PM, Ian Munsie wrote: > > @@ -346,7 +350,7 @@ ssize_t afu_read(struct file *file, char __user *buf, > size_t count, > > for (;;) { > prepare_to_wait(&ctx->wq, &wait, TASK_INTERRUPTIBLE); > - if (ctx_even

[PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events

2016-03-07 Thread Ian Munsie
From: Ian Munsie This adds an afu_driver_ops structure with event_pending and deliver_event callbacks. An AFU driver such as cxlflash can fill these out and associate it with a context to enable passing custom AFU specific events to userspace. The cxl driver will call event_pending() during poll