Re: [PATCH v2 1/2] Use kacpi_hotplug_wq to handle container hotplug event.

2012-10-24 Thread Yasuaki Ishimatsu
Hi Tang, 2012/10/24 16:24, Tang Chen wrote: > On 10/24/2012 02:54 PM, Yasuaki Ishimatsu wrote: >> Hi Tang, >> >> 2012/10/24 15:05, Tang Chen wrote: >>> As the comments in __acpi_os_execute() said: >>> >>> We can't run hotplug code in keventd_wq/kacpid_wq/kacpid_notify_wq >>> because the ho

Re: [PATCH v2 1/2] Use kacpi_hotplug_wq to handle container hotplug event.

2012-10-24 Thread Tang Chen
On 10/24/2012 02:54 PM, Yasuaki Ishimatsu wrote: > Hi Tang, > > 2012/10/24 15:05, Tang Chen wrote: >> As the comments in __acpi_os_execute() said: >> >> We can't run hotplug code in keventd_wq/kacpid_wq/kacpid_notify_wq >> because the hotplug code may call driver .remove() functions, >>

Re: [PATCH v2 1/2] Use kacpi_hotplug_wq to handle container hotplug event.

2012-10-24 Thread Tang Chen
Hi Ishimatsu-san: By the way, if you want to reproduce this problem, just modify my patch1 to call __container_notify_cb() directly in container_notify_cb(). And apply my patch2. Then, you add a container, and remove it. The deadlock will be triggered. And this patch is based on Lu Yinghai's tre

Re: [PATCH v2 1/2] Use kacpi_hotplug_wq to handle container hotplug event.

2012-10-23 Thread Yasuaki Ishimatsu
Hi Tang, 2012/10/24 15:05, Tang Chen wrote: > As the comments in __acpi_os_execute() said: > > We can't run hotplug code in keventd_wq/kacpid_wq/kacpid_notify_wq > because the hotplug code may call driver .remove() functions, > which invoke flush_scheduled_work/acpi_os_wait_even

[PATCH v2 1/2] Use kacpi_hotplug_wq to handle container hotplug event.

2012-10-23 Thread Tang Chen
As the comments in __acpi_os_execute() said: We can't run hotplug code in keventd_wq/kacpid_wq/kacpid_notify_wq because the hotplug code may call driver .remove() functions, which invoke flush_scheduled_work/acpi_os_wait_events_complete to flush these workqueues. w