Re: [PATCH v2 1/2] SPI: Add driver for Cadence SPI controller

2014-04-04 Thread Peter Crosthwaite
On Thu, Apr 3, 2014 at 9:10 PM, Harini Katakam wrote: > Add driver for Cadence SPI controller. This is used in Xilinx Zynq. > > Signed-off-by: Harini Katakam > --- > > v2 changes: > - Use xilinx compatible string too. > - Changes read register and write register functions to static inline. > - Re

Re: [PATCH v2 1/2] SPI: Add driver for Cadence SPI controller

2014-04-04 Thread Michal Simek
Hi Sourav On 04/04/2014 11:24 AM, sourav wrote: > HI, > On Friday 04 April 2014 02:34 PM, sourav wrote: >> Hi Harini, >> On Thursday 03 April 2014 04:40 PM, Harini Katakam wrote: >>> Add driver for Cadence SPI controller. This is used in Xilinx Zynq. >>> >>> Signed-off-by: Harini Katakam >>> --- >

Re: [PATCH v2 1/2] SPI: Add driver for Cadence SPI controller

2014-04-04 Thread sourav
HI, On Friday 04 April 2014 02:34 PM, sourav wrote: Hi Harini, On Thursday 03 April 2014 04:40 PM, Harini Katakam wrote: Add driver for Cadence SPI controller. This is used in Xilinx Zynq. Signed-off-by: Harini Katakam --- I had looked at cadence qspi controller. What I can see is that your pa

Re: [PATCH v2 1/2] SPI: Add driver for Cadence SPI controller

2014-04-04 Thread sourav
Hi Harini, On Thursday 03 April 2014 04:40 PM, Harini Katakam wrote: Add driver for Cadence SPI controller. This is used in Xilinx Zynq. Signed-off-by: Harini Katakam --- I had looked at cadence qspi controller. What I can see is that your patch implements "normal spi ode of operation" ? and th

Re: [PATCH v2 1/2] SPI: Add driver for Cadence SPI controller

2014-04-03 Thread Harini Katakam
Hi Mark On Fri, Apr 4, 2014 at 3:13 AM, Mark Brown wrote: > On Thu, Apr 03, 2014 at 04:40:30PM +0530, Harini Katakam wrote: >> Add driver for Cadence SPI controller. This is used in Xilinx Zynq. > > I just reviewed a driver for "Zynq Quad SPI controller" from Punnaiah > Choudary Kalluri (CCed) wh

Re: [PATCH v2 1/2] SPI: Add driver for Cadence SPI controller

2014-04-03 Thread Mark Brown
On Thu, Apr 03, 2014 at 04:40:30PM +0530, Harini Katakam wrote: > Add driver for Cadence SPI controller. This is used in Xilinx Zynq. I just reviewed a driver for "Zynq Quad SPI controller" from Punnaiah Choudary Kalluri (CCed) which seems *very* similar to this one. Are there opportunities for c

[PATCH v2 1/2] SPI: Add driver for Cadence SPI controller

2014-04-03 Thread Harini Katakam
Add driver for Cadence SPI controller. This is used in Xilinx Zynq. Signed-off-by: Harini Katakam --- v2 changes: - Use xilinx compatible string too. - Changes read register and write register functions to static inline. - Removed unecessary dev_info and dev_dbg prints. - Return IRQ_HANDLED only