Re: [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver

2020-08-14 Thread Jiaxin Yu
On Thu, 2020-08-13 at 16:44 +0100, Mark Brown wrote: > On Thu, Aug 13, 2020 at 11:40:00PM +0800, Jiaxin Yu wrote: > > On Wed, 2020-08-12 at 13:05 +0100, Mark Brown wrote: > > > > These functions are exported for other drivers to use rather than > > > something done internally by the driver - if th

Re: [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver

2020-08-13 Thread Mark Brown
On Thu, Aug 13, 2020 at 11:40:00PM +0800, Jiaxin Yu wrote: > On Wed, 2020-08-12 at 13:05 +0100, Mark Brown wrote: > > These functions are exported for other drivers to use rather than > > something done internally by the driver - if this were internal to the > > driver it'd not be a big deal but w

Re: [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver

2020-08-13 Thread Jiaxin Yu
On Wed, 2020-08-12 at 13:05 +0100, Mark Brown wrote: > On Wed, Aug 12, 2020 at 03:29:13PM +0800, Jiaxin Yu wrote: > > On Mon, 2020-08-10 at 19:59 +0100, Mark Brown wrote: > > > On Mon, Aug 10, 2020 at 11:05:53AM +0800, Jiaxin Yu wrote: > > > > > +void mt6359_set_playback_gpio(struct snd_soc_compon

Re: [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver

2020-08-12 Thread Mark Brown
On Wed, Aug 12, 2020 at 03:29:13PM +0800, Jiaxin Yu wrote: > On Mon, 2020-08-10 at 19:59 +0100, Mark Brown wrote: > > On Mon, Aug 10, 2020 at 11:05:53AM +0800, Jiaxin Yu wrote: > > > +void mt6359_set_playback_gpio(struct snd_soc_component *cmpnt) > > > +{ > > > + struct mt6359_priv *priv = snd_soc

Re: [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver

2020-08-12 Thread Jiaxin Yu
On Mon, 2020-08-10 at 19:59 +0100, Mark Brown wrote: > On Mon, Aug 10, 2020 at 11:05:53AM +0800, Jiaxin Yu wrote: > > > +void mt6359_set_playback_gpio(struct snd_soc_component *cmpnt) > > +{ > > + struct mt6359_priv *priv = snd_soc_component_get_drvdata(cmpnt); > > > +void mt6359_reset_playback

Re: [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver

2020-08-10 Thread Mark Brown
On Mon, Aug 10, 2020 at 11:05:53AM +0800, Jiaxin Yu wrote: > +void mt6359_set_playback_gpio(struct snd_soc_component *cmpnt) > +{ > + struct mt6359_priv *priv = snd_soc_component_get_drvdata(cmpnt); > +void mt6359_reset_playback_gpio(struct snd_soc_component *cmpnt) > +{ > + struct mt6359

Re: [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver

2020-08-10 Thread Tzung-Bi Shih
On Mon, Aug 10, 2020 at 11:11 AM Jiaxin Yu wrote: > > Add the mt6359 codec driver. > > Signed-off-by: Jiaxin Yu Reviewed-by: Tzung-Bi Shih This patch also reviewed few rounds on https://crrev.com/c/2299951