Re: [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag

2019-06-28 Thread Jeremy Linton
Hi, On 6/19/19 4:15 AM, John Garry wrote: On 18/06/2019 22:28, Jeremy Linton wrote: Hi, On 6/18/19 12:23 PM, John Garry wrote: On 18/06/2019 15:40, Valentin Schneider wrote: On 18/06/2019 15:21, Jeremy Linton wrote: [...] + * Return: -ENOENT if the PPTT doesn't exist, the CPU cannot be foun

Re: [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag

2019-06-25 Thread Sudeep Holla
On Mon, Jun 17, 2019 at 01:34:51PM +0100, Valentin Schneider wrote: > Hi Jeremy, > > Few nits below. > > Also, I had a look at the other PPTT processor flags that were introduced > in 6.3, and the only other one being used is ACPI_LEAF_NODE in > acpi_pptt_leaf_node(). However that one already has a

Re: [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag

2019-06-19 Thread John Garry
On 18/06/2019 22:28, Jeremy Linton wrote: Hi, On 6/18/19 12:23 PM, John Garry wrote: On 18/06/2019 15:40, Valentin Schneider wrote: On 18/06/2019 15:21, Jeremy Linton wrote: [...] + * Return: -ENOENT if the PPTT doesn't exist, the CPU cannot be found or + * the table revision isn't new

Re: [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag

2019-06-18 Thread Jeremy Linton
Hi, On 6/18/19 12:23 PM, John Garry wrote: On 18/06/2019 15:40, Valentin Schneider wrote: On 18/06/2019 15:21, Jeremy Linton wrote: [...] + * Return: -ENOENT if the PPTT doesn't exist, the CPU cannot be found or + *   the table revision isn't new enough. + * Otherwise returns flag value +

Re: [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag

2019-06-18 Thread John Garry
On 18/06/2019 15:40, Valentin Schneider wrote: On 18/06/2019 15:21, Jeremy Linton wrote: [...] + * Return: -ENOENT if the PPTT doesn't exist, the CPU cannot be found or + * the table revision isn't new enough. + * Otherwise returns flag value + */ Nit: strictly speaking we're not returni

Re: [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag

2019-06-18 Thread Valentin Schneider
On 18/06/2019 15:21, Jeremy Linton wrote: [...] >>> + * Return: -ENOENT if the PPTT doesn't exist, the CPU cannot be found or >>> + *   the table revision isn't new enough. >>> + * Otherwise returns flag value >>> + */ >> >> Nit: strictly speaking we're not returning the flag value but its mask

Re: [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag

2019-06-18 Thread Jeremy Linton
On 6/17/19 7:34 AM, Valentin Schneider wrote: Hi Jeremy, Few nits below. Also, I had a look at the other PPTT processor flags that were introduced in 6.3, and the only other one being used is ACPI_LEAF_NODE in acpi_pptt_leaf_node(). However that one already has a handle on the table header, so

Re: [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag

2019-06-17 Thread Valentin Schneider
Hi Jeremy, Few nits below. Also, I had a look at the other PPTT processor flags that were introduced in 6.3, and the only other one being used is ACPI_LEAF_NODE in acpi_pptt_leaf_node(). However that one already has a handle on the table header, so the check_acpi_cpu_flag() isn't of much help the

[PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag

2019-06-14 Thread Jeremy Linton
ACPI 6.3 adds a flag to the CPU node to indicate whether the given PE is a thread. Add a function to return that information for a given linux logical CPU. Signed-off-by: Jeremy Linton --- drivers/acpi/pptt.c | 53 +++- include/linux/acpi.h | 5 + 2