Re: [PATCH v2 1/1] staging: ozwpan: Remove allocation from delaration line

2015-02-10 Thread Joe Perches
On Tue, 2015-02-10 at 13:13 +0300, Dan Carpenter wrote: > > diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c [] > > @@ -280,8 +280,9 @@ static void oz_free_urb_link(struct oz_urb_link *urbl) > > */ > > static struct oz_endpoint *oz_ep_alloc(int buffer_size, gfp_t mem_

Re: [PATCH v2 1/1] staging: ozwpan: Remove allocation from delaration line

2015-02-10 Thread Dan Carpenter
Looks good. Thanks! > diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c > index 8543bb2..96e95bf 100644 > --- a/drivers/staging/ozwpan/ozhcd.c > +++ b/drivers/staging/ozwpan/ozhcd.c > @@ -280,8 +280,9 @@ static void oz_free_urb_link(struct oz_urb_link *urbl) > */ > s

[PATCH v2 1/1] staging: ozwpan: Remove allocation from delaration line

2015-02-10 Thread Quentin Lambert
This patch removes allocation from declaration line because people are known to gloss over declarations. Signed-off-by: Quentin Lambert --- Changes since v1: - Remove the blank line between allocation and NULL check drivers/staging/ozwpan/ozhcd.c | 5 +++-- drivers/staging/ozwpan/ozpd.c | 8