Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim writes: > Conventionally, we put output param to the end of param list. > cma_declare_contiguous() doesn't look like that, so change it. > > Additionally, move down cma_areas reference code to the position > where it is really needed. > > Signed-off-by: Joonsoo Kim Reviewed-by: Anee

Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

2014-06-12 Thread Michal Nazarewicz
On Thu, Jun 12 2014, Joonsoo Kim wrote: > Conventionally, we put output param to the end of param list. > cma_declare_contiguous() doesn't look like that, so change it. Perhaps the function should be changed to return an error-pointer? > Additionally, move down cma_areas reference code to the po

Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

2014-06-12 Thread Joonsoo Kim
On Thu, Jun 12, 2014 at 04:19:31PM +0900, Minchan Kim wrote: > On Thu, Jun 12, 2014 at 12:21:46PM +0900, Joonsoo Kim wrote: > > Conventionally, we put output param to the end of param list. > > cma_declare_contiguous() doesn't look like that, so change it. > > If you says "Conventionally", I'd lik

Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

2014-06-12 Thread Minchan Kim
On Thu, Jun 12, 2014 at 12:21:46PM +0900, Joonsoo Kim wrote: > Conventionally, we put output param to the end of param list. > cma_declare_contiguous() doesn't look like that, so change it. If you says "Conventionally", I'd like to suggest one more thing. Conventionally, we put 'base' ahead 'size'

[PATCH v2 09/10] mm, cma: move output param to the end of param list

2014-06-11 Thread Joonsoo Kim
Conventionally, we put output param to the end of param list. cma_declare_contiguous() doesn't look like that, so change it. Additionally, move down cma_areas reference code to the position where it is really needed. Signed-off-by: Joonsoo Kim diff --git a/arch/powerpc/kvm/book3s_hv_builtin.c