Re: [PATCH v2 08/11] ext4: lost brelse in ext4_orphan_add()

2018-11-06 Thread Theodore Y. Ts'o
On Wed, Oct 31, 2018 at 12:58:31AM +0300, Vasily Averin wrote: > iloc.bh os taken in ext4_reserve_inode_write(). > If (dirty == true) it is released in ext4_mark_iloc_dirty(), > however it is not released in (dirty == false) case. > > Fixes d745a8c20c1f ("ext4: reduce contention on s_orphan_lock")

[PATCH v2 08/11] ext4: lost brelse in ext4_orphan_add()

2018-10-30 Thread Vasily Averin
iloc.bh os taken in ext4_reserve_inode_write(). If (dirty == true) it is released in ext4_mark_iloc_dirty(), however it is not released in (dirty == false) case. Fixes d745a8c20c1f ("ext4: reduce contention on s_orphan_lock") however iloc.bh count balance was broken earlier by Fixes 6e3617e579e0 (