Re: [PATCH v2 07/21] x86/io: Remove useless definition of mmiowb()

2019-04-05 Thread Thomas Gleixner
On Fri, 5 Apr 2019, Will Deacon wrote: > x86 maps mmiowb() to barrier(), but this is superfluous because a > compiler barrier is already implied by spin_unlock(). Since x86 also > includes asm-generic/io.h in its asm/io.h file, we can remove the s/we can// > definition entirely and pick up the d

[PATCH v2 07/21] x86/io: Remove useless definition of mmiowb()

2019-04-05 Thread Will Deacon
x86 maps mmiowb() to barrier(), but this is superfluous because a compiler barrier is already implied by spin_unlock(). Since x86 also includes asm-generic/io.h in its asm/io.h file, we can remove the definition entirely and pick up the dummy definition from core code. Signed-off-by: Will Deacon