Re: [PATCH v2 07/17] fs: new infrastructure for writeback error handling and reporting

2017-04-17 Thread NeilBrown
On Wed, Apr 12 2017, Jeff Layton wrote: > On Thu, 2017-04-13 at 07:55 +1000, NeilBrown wrote: >> On Wed, Apr 12 2017, Jeff Layton wrote: >> >> >> > +void __filemap_set_wb_error(struct address_space *mapping, int err) >> >> I was really hoping that this would be >> >> void __set_wb_error(wb_e

Re: [PATCH v2 07/17] fs: new infrastructure for writeback error handling and reporting

2017-04-12 Thread Jeff Layton
On Thu, 2017-04-13 at 07:55 +1000, NeilBrown wrote: > On Wed, Apr 12 2017, Jeff Layton wrote: > > > > +void __filemap_set_wb_error(struct address_space *mapping, int err) > > I was really hoping that this would be > > void __set_wb_error(wb_err_t *wb_err, int err) > > so > > Then nfs_contex

Re: [PATCH v2 07/17] fs: new infrastructure for writeback error handling and reporting

2017-04-12 Thread NeilBrown
On Wed, Apr 12 2017, Jeff Layton wrote: > +void __filemap_set_wb_error(struct address_space *mapping, int err) I was really hoping that this would be void __set_wb_error(wb_err_t *wb_err, int err) so Then nfs_context_set_write_error could become static void nfs_context_set_write_error(stru

Re: [PATCH v2 07/17] fs: new infrastructure for writeback error handling and reporting

2017-04-12 Thread Jeff Layton
My apologies, this patch in particular should have gotten an updated changelog. Here's a revised patch. The only real difference in this is the updated changelog. 8< [PATCH] fs: new infrastructure for writeback error handling and reporti

[PATCH v2 07/17] fs: new infrastructure for writeback error handling and reporting

2017-04-12 Thread Jeff Layton
Most filesystems currently use mapping_set_error and filemap_check_errors for setting and reporting/clearing writeback errors at the mapping level. filemap_check_errors is indirectly called from most of the filemap_fdatawait_* functions and from filemap_write_and_wait*. These functions are called f