Re: [PATCH v2 06/15] arm: npcm: fix a leaked reference by adding missing of_node_put

2019-03-06 Thread Avi Fishman
On Tue, Mar 5, 2019 at 1:33 PM Wen Yang wrote: > > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-npcm/platsmp.c:52:1-7: ERROR:

[PATCH v2 06/15] arm: npcm: fix a leaked reference by adding missing of_node_put

2019-03-05 Thread Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/arm/mach-npcm/platsmp.c:52:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount