Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900

2016-07-12 Thread Arnd Bergmann
On Tuesday, July 12, 2016 5:06:10 PM CEST Wan Zongshun wrote: > On 2016年07月11日 16:03, Arnd Bergmann wrote: > > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > > I'm still a bit unsure about the set of attributes here. > > > > - The "soc_id" is read from the device tree from the field

Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900

2016-07-12 Thread Wan Zongshun
On 2016年07月11日 16:03, Arnd Bergmann wrote: On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: + ret = of_property_read_string(np, "compatible", &soc_dev_attr->soc_id); + if (ret) return -EINVAL; + + soc_dev_attr->machine = "NUC900EVB"; + soc_dev

Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900

2016-07-11 Thread Arnd Bergmann
On Monday, July 11, 2016 6:28:57 PM CEST Wan ZongShun wrote: > 2016-07-11 18:24 GMT+08:00 Arnd Bergmann : > > On Monday, July 11, 2016 5:07:01 PM CEST Wan Zongshun wrote: > >> > >> On 2016年07月11日 16:03, Arnd Bergmann wrote: > >> > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > >> >>

Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900

2016-07-11 Thread Wan ZongShun
2016-07-11 18:24 GMT+08:00 Arnd Bergmann : > On Monday, July 11, 2016 5:07:01 PM CEST Wan Zongshun wrote: >> >> On 2016年07月11日 16:03, Arnd Bergmann wrote: >> > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: >> >> + ret = of_property_read_string(np, "compatible", >> >> &soc_dev_

Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900

2016-07-11 Thread Arnd Bergmann
On Monday, July 11, 2016 5:07:01 PM CEST Wan Zongshun wrote: > > On 2016年07月11日 16:03, Arnd Bergmann wrote: > > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > >> + ret = of_property_read_string(np, "compatible", > >> &soc_dev_attr->soc_id); > >> + if (ret) > >>

Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900

2016-07-11 Thread Wan Zongshun
On 2016年07月11日 16:03, Arnd Bergmann wrote: On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: + ret = of_property_read_string(np, "compatible", &soc_dev_attr->soc_id); + if (ret) return -EINVAL; + + soc_dev_attr->machine = "NUC900EVB"; + soc_dev

Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900

2016-07-11 Thread Arnd Bergmann
On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > + ret = of_property_read_string(np, "compatible", > &soc_dev_attr->soc_id); > + if (ret) > return -EINVAL; > + > + soc_dev_attr->machine = "NUC900EVB"; > + soc_dev_attr->family = "NUC900"; > +

[PATCH v2 06/10] soc: Add SoC specific driver support for nuc900

2016-07-10 Thread Wan Zongshun
This patch is to add SoC specific driver for nuc970 SoC, it is for getting nuc970 version id and chip id. Signed-off-by: Wan Zongshun --- drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/nuvoton/Kconfig | 10 drivers/soc/nuvoton/Makefile