Re: [PATCH v2 05/17] workqueue: use WARN_ON_FUNCTION_MISMATCH

2021-03-18 Thread Sami Tolvanen
On Thu, Mar 18, 2021 at 11:50 AM Nick Desaulniers wrote: > > On Thu, Mar 18, 2021 at 10:11 AM Sami Tolvanen > wrote: > > > > With CONFIG_CFI_CLANG, a callback function passed to > > __queue_delayed_work from a module points to a jump table entry > > defined in the module instead of the one used

Re: [PATCH v2 05/17] workqueue: use WARN_ON_FUNCTION_MISMATCH

2021-03-18 Thread Nick Desaulniers
On Thu, Mar 18, 2021 at 10:11 AM Sami Tolvanen wrote: > > With CONFIG_CFI_CLANG, a callback function passed to > __queue_delayed_work from a module points to a jump table entry > defined in the module instead of the one used in the core kernel, > which breaks function address equality in this chec

[PATCH v2 05/17] workqueue: use WARN_ON_FUNCTION_MISMATCH

2021-03-18 Thread Sami Tolvanen
With CONFIG_CFI_CLANG, a callback function passed to __queue_delayed_work from a module points to a jump table entry defined in the module instead of the one used in the core kernel, which breaks function address equality in this check: WARN_ON_ONCE(timer->function != delayed_work_timer_fn); Us