Re: [PATCH v2 05/13] iommu/rockchip: Fix error handling in init

2018-01-17 Thread Tomasz Figa
On Wed, Jan 17, 2018 at 4:19 PM, Tomasz Figa wrote: > > P.S. Looks like your email client is set to HTML messages. Your > messages might end up dropped from the mailing list. Never mind. Looks like gmail started displaying quotations in plain text as graphics. Best regards, Tomasz

Re: [PATCH v2 05/13] iommu/rockchip: Fix error handling in init

2018-01-17 Thread Robin Murphy
On 17/01/18 05:26, Tomasz Figa wrote: On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: It's hard to undo bus_set_iommu() in the error path, so move it to the end of rk_iommu_probe(). Does this work fine now? I remember we used to need this called in an early initcall for all the ARM/ARM64

Re: [PATCH v2 05/13] iommu/rockchip: Fix error handling in init

2018-01-16 Thread Tomasz Figa
On Wed, Jan 17, 2018 at 4:14 PM, JeffyChen wrote: > Hi Tomasz, > > On 01/17/2018 01:26 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >>> >>> It's hard to undo bus_set_iommu() in the error path, so move it to the >>> end of rk_iommu_probe(). >> >> >> Does this

Re: [PATCH v2 05/13] iommu/rockchip: Fix error handling in init

2018-01-16 Thread Tomasz Figa
On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > It's hard to undo bus_set_iommu() in the error path, so move it to the > end of rk_iommu_probe(). Does this work fine now? I remember we used to need this called in an early initcall for all the ARM/ARM64 DMA stuff to work. Best regards, Toma

[PATCH v2 05/13] iommu/rockchip: Fix error handling in init

2018-01-16 Thread Jeffy Chen
It's hard to undo bus_set_iommu() in the error path, so move it to the end of rk_iommu_probe(). Signed-off-by: Jeffy Chen --- Changes in v2: Move bus_set_iommu() to rk_iommu_probe(). drivers/iommu/rockchip-iommu.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) dif