Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization

2013-11-03 Thread David Long
On 11/01/13 09:52, Oleg Nesterov wrote: On 10/31, David Long wrote: On 10/28/13 14:58, Oleg Nesterov wrote: On 10/22, David Long wrote: I simply do not understand why uprobes.c uses module_init/module_exit, it can't be compiled as a module. I guess that makes sense, assuming it can never be m

Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization

2013-11-01 Thread Oleg Nesterov
On 10/31, David Long wrote: > On 10/28/13 14:58, Oleg Nesterov wrote: >> On 10/22, David Long wrote: >> I simply do not understand why uprobes.c uses module_init/module_exit, >> it can't be compiled as a module. > > I guess that makes sense, assuming it can never be made a module. I saw > you rece

Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization

2013-10-31 Thread David Long
On 10/28/13 14:58, Oleg Nesterov wrote: On 10/22, David Long wrote: I simply do not understand why uprobes.c uses module_init/module_exit, it can't be compiled as a module. I guess that makes sense, assuming it can never be made a module. I saw you recent commit for this. I think that modu

Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization

2013-10-28 Thread Oleg Nesterov
On 10/22, David Long wrote: > > On 10/19/13 12:42, Oleg Nesterov wrote: >> On 10/15, David Long wrote: >>> >>> Add a weak function for any architecture-specific initialization. ARM >>> will use this to register the handlers for the undefined instructions it >>> uses to implement uprobes. >> >> Cou

Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization

2013-10-22 Thread David Long
On 10/19/13 12:42, Oleg Nesterov wrote: On 10/15, David Long wrote: Add a weak function for any architecture-specific initialization. ARM will use this to register the handlers for the undefined instructions it uses to implement uprobes. Could you explain why ARM can't simply do the necessar

Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization

2013-10-19 Thread Oleg Nesterov
On 10/15, David Long wrote: > > Add a weak function for any architecture-specific initialization. ARM > will use this to register the handlers for the undefined instructions it > uses to implement uprobes. Could you explain why ARM can't simply do the necessary initialization in arch/arm/kernel/u

[PATCH v2 04/13] uprobes: allow arch-specific initialization

2013-10-15 Thread David Long
From: Rabin Vincent Add a weak function for any architecture-specific initialization. ARM will use this to register the handlers for the undefined instructions it uses to implement uprobes. Signed-off-by: Rabin Vincent Signed-off-by: David A. Long --- include/linux/uprobes.h | 1 + kernel/e