Re: [PATCH v2 03/18] gpiolib: make cdev a build option

2020-07-27 Thread Linus Walleij
On Mon, Jul 27, 2020 at 7:57 AM Kent Gibson wrote: > I've gone with this: > > +config GPIO_CDEV > + bool > + prompt "Character device (/dev/gpiochipN) support" if EXPERT > + default y > > so the entry is always present in menuconfig, and GPIO_CDEV_V1 can still > depend on it, bu

Re: [PATCH v2 03/18] gpiolib: make cdev a build option

2020-07-26 Thread Kent Gibson
On Mon, Jul 27, 2020 at 09:46:01AM +0800, Kent Gibson wrote: > On Mon, Jul 27, 2020 at 12:25:53AM +0200, Linus Walleij wrote: > > On Sat, Jul 25, 2020 at 6:21 AM Kent Gibson wrote: > > > > > +config GPIO_CDEV > > > + bool "/dev/gpiochipN (character device interface)" > > > + default y

Re: [PATCH v2 03/18] gpiolib: make cdev a build option

2020-07-26 Thread Kent Gibson
On Mon, Jul 27, 2020 at 12:25:53AM +0200, Linus Walleij wrote: > On Sat, Jul 25, 2020 at 6:21 AM Kent Gibson wrote: > > > +config GPIO_CDEV > > + bool "/dev/gpiochipN (character device interface)" > > + default y > > I don't want to make it too easy to do this, as I see it as a stand

Re: [PATCH v2 03/18] gpiolib: make cdev a build option

2020-07-26 Thread Linus Walleij
On Sat, Jul 25, 2020 at 6:21 AM Kent Gibson wrote: > +config GPIO_CDEV > + bool "/dev/gpiochipN (character device interface)" > + default y I don't want to make it too easy to do this, as I see it as a standard kernel feature. Can we add: depends on EXPERT as with other standard k

Re: [PATCH v2 03/18] gpiolib: make cdev a build option

2020-07-25 Thread Andy Shevchenko
On Sat, Jul 25, 2020 at 7:21 AM Kent Gibson wrote: > > Make the gpiolib-cdev module a build option. This allows the CDEV > interface to be removed from the kernel to reduce kernel size in > applications where is it not required, and provides the parent for > other other CDEV interface specific bu

[PATCH v2 03/18] gpiolib: make cdev a build option

2020-07-24 Thread Kent Gibson
Make the gpiolib-cdev module a build option. This allows the CDEV interface to be removed from the kernel to reduce kernel size in applications where is it not required, and provides the parent for other other CDEV interface specific build options to follow. Suggested-by: Bartosz Golaszewski Sig