Re: [PATCH v2 03/10] mfd: wcd9335: add wcd irq support

2018-08-02 Thread Srinivas Kandagatla
On 02/08/18 11:01, Lee Jones wrote: Any particular reason for separating out IRQ handling? No particular reason, I tried to follow what other codecs like wm8994, wm8350 and 14 others do. I haven't look at them in a while, but maybe theirs are optional? Either way, I don't think you need to

Re: [PATCH v2 03/10] mfd: wcd9335: add wcd irq support

2018-08-02 Thread Lee Jones
On Thu, 02 Aug 2018, Srinivas Kandagatla wrote: > Thanks for the review, > > On 02/08/18 09:05, Lee Jones wrote: > > On Fri, 27 Jul 2018, Srinivas Kandagatla wrote: > > > > > WCD9335 supports two lines of irqs INTR1 and INTR2. > > > Multiple interrupts are muxed via these lines. > > > INTR1 cons

Re: [PATCH v2 03/10] mfd: wcd9335: add wcd irq support

2018-08-02 Thread Srinivas Kandagatla
Thanks for the review, On 02/08/18 09:05, Lee Jones wrote: On Fri, 27 Jul 2018, Srinivas Kandagatla wrote: WCD9335 supports two lines of irqs INTR1 and INTR2. Multiple interrupts are muxed via these lines. INTR1 consists of all possible interrupt sources like: Ear OCP, HPH OCP, MBHC, MAD, VBAT

Re: [PATCH v2 03/10] mfd: wcd9335: add wcd irq support

2018-08-02 Thread Lee Jones
On Fri, 27 Jul 2018, Srinivas Kandagatla wrote: > WCD9335 supports two lines of irqs INTR1 and INTR2. > Multiple interrupts are muxed via these lines. > INTR1 consists of all possible interrupt sources like: > Ear OCP, HPH OCP, MBHC, MAD, VBAT, and SVA > INTR2 is a subset of first interrupt source

Re: [PATCH v2 03/10] mfd: wcd9335: add wcd irq support

2018-08-02 Thread Srinivas Kandagatla
Thanks for review, On 01/08/18 23:17, Rob Herring wrote: On Wed, Aug 1, 2018 at 2:57 AM Srinivas Kandagatla wrote: Thanks for the review, On 31/07/18 21:45, Rob Herring wrote: On Fri, Jul 27, 2018 at 01:17:59PM +0100, Srinivas Kandagatla wrote: WCD9335 supports two lines of irqs INTR1 and

Re: [PATCH v2 03/10] mfd: wcd9335: add wcd irq support

2018-08-01 Thread Rob Herring
On Wed, Aug 1, 2018 at 2:57 AM Srinivas Kandagatla wrote: > > Thanks for the review, > > On 31/07/18 21:45, Rob Herring wrote: > > On Fri, Jul 27, 2018 at 01:17:59PM +0100, Srinivas Kandagatla wrote: > >> WCD9335 supports two lines of irqs INTR1 and INTR2. > >> Multiple interrupts are muxed via th

Re: [PATCH v2 03/10] mfd: wcd9335: add wcd irq support

2018-08-01 Thread Srinivas Kandagatla
Thanks for the review, On 31/07/18 21:45, Rob Herring wrote: On Fri, Jul 27, 2018 at 01:17:59PM +0100, Srinivas Kandagatla wrote: WCD9335 supports two lines of irqs INTR1 and INTR2. Multiple interrupts are muxed via these lines. INTR1 consists of all possible interrupt sources like: Ear OCP, HP

Re: [PATCH v2 03/10] mfd: wcd9335: add wcd irq support

2018-07-31 Thread Rob Herring
On Fri, Jul 27, 2018 at 01:17:59PM +0100, Srinivas Kandagatla wrote: > WCD9335 supports two lines of irqs INTR1 and INTR2. > Multiple interrupts are muxed via these lines. > INTR1 consists of all possible interrupt sources like: > Ear OCP, HPH OCP, MBHC, MAD, VBAT, and SVA > INTR2 is a subset of fi

[PATCH v2 03/10] mfd: wcd9335: add wcd irq support

2018-07-27 Thread Srinivas Kandagatla
WCD9335 supports two lines of irqs INTR1 and INTR2. Multiple interrupts are muxed via these lines. INTR1 consists of all possible interrupt sources like: Ear OCP, HPH OCP, MBHC, MAD, VBAT, and SVA INTR2 is a subset of first interrupt sources like MAD, VBAT, and SVA Signed-off-by: Srinivas Kandagat