Re: [PATCH v2 02/24] exec: Simplify unshare_files

On Mon, Nov 23, 2020 at 10:25:13AM -0800, Linus Torvalds wrote: > On Mon, Nov 23, 2020 at 9:52 AM Oleg Nesterov wrote: > > > > Can anyone explain why does do_coredump() need unshare_files() at all? > > Hmm. It goes back to 2012, and it's placed just before calling > "->core_dump()", so I assume s

Re: [PATCH v2 02/24] exec: Simplify unshare_files

Arnd Bergmann writes: ... > > If there are no objections, I can also send a patch to remove > CONFIG_PPC_CELL_NATIVE, PPC_IBM_CELL_BLADE and > everything that depends on those symbols, leaving only the > bits needed by ps3 in the arch/powerpc/platforms/cell directory. I'm not sure I'd merge it.

Re: [PATCH v2 02/24] exec: Simplify unshare_files

Arnd Bergmann writes: > On Wed, Nov 25, 2020 at 2:16 AM Eric W. Biederman > wrote: >> > On 11/24/20 12:14 PM, Arnd Bergmann wrote: >> > >> > There are still PS3-Linux users out there. They use 'Homebrew' firmware >> > released through 'Hacker' forums that allow them to run Linux on >> > non-su

Re: [PATCH v2 02/24] exec: Simplify unshare_files

On Wed, Nov 25, 2020 at 2:16 AM Eric W. Biederman wrote: > > On 11/24/20 12:14 PM, Arnd Bergmann wrote: > > > > There are still PS3-Linux users out there. They use 'Homebrew' firmware > > released through 'Hacker' forums that allow them to run Linux on > > non-supported systems. They are general

Re: [PATCH v2 02/24] exec: Simplify unshare_files

Geoff Levand writes: > On 11/24/20 12:14 PM, Arnd Bergmann wrote: >> On Tue, Nov 24, 2020 at 8:58 PM Linus Torvalds >> wrote: >>> >>> On Tue, Nov 24, 2020 at 11:55 AM Eric W. Biederman >>> wrote: If cell happens to be dead we can remove a fair amount of generic kernel code that o

Re: [PATCH v2 02/24] exec: Simplify unshare_files

On 11/24/20 12:14 PM, Arnd Bergmann wrote: > On Tue, Nov 24, 2020 at 8:58 PM Linus Torvalds > wrote: >> >> On Tue, Nov 24, 2020 at 11:55 AM Eric W. Biederman >> wrote: >>> >>> If cell happens to be dead we can remove a fair amount of generic kernel >>> code that only exists to support cell. >> >>

Re: [PATCH v2 02/24] exec: Simplify unshare_files

On Tue, Nov 24, 2020 at 8:58 PM Linus Torvalds wrote: > > On Tue, Nov 24, 2020 at 11:55 AM Eric W. Biederman > wrote: > > > > If cell happens to be dead we can remove a fair amount of generic kernel > > code that only exists to support cell. > > Even if some people might still use cell (which sou

Re: [PATCH v2 02/24] exec: Simplify unshare_files

On Tue, Nov 24, 2020 at 11:55 AM Eric W. Biederman wrote: > > If cell happens to be dead we can remove a fair amount of generic kernel > code that only exists to support cell. Even if some people might still use cell (which sounds unlikely), I think we can remove the spu core dumping code.

Re: [PATCH v2 02/24] exec: Simplify unshare_files

On Mon, Nov 23, 2020 at 9:52 AM Oleg Nesterov wrote: > > Can anyone explain why does do_coredump() need unshare_files() at all? Hmm. It goes back to 2012, and it's placed just before calling "->core_dump()", so I assume some core dumping function messed with the file table back when.. I can't se

Re: [PATCH v2 02/24] exec: Simplify unshare_files

I'll try to actually read this series tomorrow but I see nothing wrong after the quick glance. Just one off-topic question, On 11/20, Eric W. Biederman wrote: > > --- a/fs/coredump.c > +++ b/fs/coredump.c > @@ -585,7 +585,6 @@ void do_coredump(const kernel_siginfo_t *siginfo) > int ispipe;

[PATCH v2 02/24] exec: Simplify unshare_files

Now that exec no longer needs to return the unshared files to their previous value there is no reason to return displaced. Instead when unshare_fd creates a copy of the file table, call put_files_struct before returning from unshare_files. Acked-by: Christian Brauner v1: https://lkml.kernel.org/