Re: [PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core

2018-08-02 Thread Lee Jones
On Thu, 02 Aug 2018, Srinivas Kandagatla wrote: > On 02/08/18 09:33, Lee Jones wrote: > > On Fri, 27 Jul 2018, Srinivas Kandagatla wrote: > > > > > Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, > > > It has mulitple blocks like Soundwire controller, codec, > > > Codec processing eng

Re: [PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core

2018-08-02 Thread Srinivas Kandagatla
Thanks for the review, On 02/08/18 09:33, Lee Jones wrote: On Fri, 27 Jul 2018, Srinivas Kandagatla wrote: Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, It has mulitple blocks like Soundwire controller, codec, Codec processing engine, ClassH controller, interrupt mux. It suppor

Re: [PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core

2018-08-02 Thread Lee Jones
On Fri, 27 Jul 2018, Srinivas Kandagatla wrote: > Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, > It has mulitple blocks like Soundwire controller, codec, > Codec processing engine, ClassH controller, interrupt mux. > It supports both I2S/I2C and SLIMbus audio interfaces. > > This

Re: [PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core

2018-08-01 Thread Srinivas Kandagatla
Thanks for reviewing, On 30/07/18 05:12, Vinod wrote: On 27-07-18, 13:17, Srinivas Kandagatla wrote: +obj-$(CONFIG_MFD_WCD9335) += wcd9335.o +wcd9335-objs := wcd9335-core.o + no slimbus objs? Yep, I will try to tidy this up a bit in next version. +static int wcd9335_

Re: [PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core

2018-07-29 Thread Vinod
On 27-07-18, 13:17, Srinivas Kandagatla wrote: > +obj-$(CONFIG_MFD_WCD9335)+= wcd9335.o > +wcd9335-objs := wcd9335-core.o > + no slimbus objs? > +static int wcd9335_bring_up(struct wcd9335 *wcd) > +{ > + struct regmap *rm = wcd->regmap; > + int val, byte0; > + int

[PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core

2018-07-27 Thread Srinivas Kandagatla
Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, It has mulitple blocks like Soundwire controller, codec, Codec processing engine, ClassH controller, interrupt mux. It supports both I2S/I2C and SLIMbus audio interfaces. This patch adds support to SLIMbus audio interface. Signed-off-by