Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-12-18 Thread Ulf Hansson
On 19 December 2017 at 04:56, Masahiro Yamada wrote: > Hi Ulf, > > > 2017-12-15 18:18 GMT+09:00 Ulf Hansson : >> On 24 November 2017 at 17:24, Masahiro Yamada >> wrote: >>> >>> I am working on this IP for Socionext SoCs. >>> >>> I was hit by several issues, and noticed various >>> clean-up candid

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-12-18 Thread Masahiro Yamada
Hi Ulf, 2017-12-15 18:18 GMT+09:00 Ulf Hansson : > On 24 November 2017 at 17:24, Masahiro Yamada > wrote: >> >> I am working on this IP for Socionext SoCs. >> >> I was hit by several issues, and noticed various >> clean-up candidates. >> >> - Fix and clean-up Kconfig >> - Fix various card dete

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-12-15 Thread Wolfram Sang
> > Other thoughts? > > Nope. I have :) Another solution seems to be to switch to ioread16_rep and friends. Those are defined on sparc64. Compiles locally here, now sent it to buildbot. signature.asc Description: PGP signature

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-12-15 Thread Wolfram Sang
> > Ulf, this patch then in deed should ideally be applied before 1-8 here. > > Okay, once you post it to linux-mmc I will pick it up, and put it in front. Bad news, that patch didn't help. The problem is that sparc64 doesn't include 'asm-generic/io.h' and also has no own 'readsw'. No surprise t

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-12-15 Thread Ulf Hansson
On 15 December 2017 at 17:30, Wolfram Sang wrote: > >> > Ulf, this patch then in deed should ideally be applied before 1-8 here. >> >> Okay, once you post it to linux-mmc I will pick it up, and put it in front. > > Bad news, that patch didn't help. The problem is that sparc64 doesn't > include 'as

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-12-15 Thread Ulf Hansson
On 15 December 2017 at 12:12, Wolfram Sang wrote: > >> After 2, COMPILE_TEST will work correctly. >> >> Then, Wolfram mentioned we would need to include from tmio_mmc.h >> >> https://patchwork.kernel.org/patch/10074333/ >> >> >> I was waiting for a patch from him. > > Yes, I am sorry. I am curren

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-12-15 Thread Wolfram Sang
> After 2, COMPILE_TEST will work correctly. > > Then, Wolfram mentioned we would need to include from tmio_mmc.h > > https://patchwork.kernel.org/patch/10074333/ > > > I was waiting for a patch from him. Yes, I am sorry. I am currently swamped with I2C work, not so much time for SDHI. Howev

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-12-15 Thread Masahiro Yamada
2017-12-15 18:18 GMT+09:00 Ulf Hansson : > On 24 November 2017 at 17:24, Masahiro Yamada > wrote: >> >> I am working on this IP for Socionext SoCs. >> >> I was hit by several issues, and noticed various >> clean-up candidates. >> >> - Fix and clean-up Kconfig >> - Fix various card detection prob

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-12-15 Thread Ulf Hansson
On 24 November 2017 at 17:24, Masahiro Yamada wrote: > > I am working on this IP for Socionext SoCs. > > I was hit by several issues, and noticed various > clean-up candidates. > > - Fix and clean-up Kconfig > - Fix various card detection problems > - Move Renesas private data out of TMIO core

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-11-27 Thread Masahiro Yamada
Hi Wolfram, 2017-11-28 2:13 GMT+09:00 Wolfram Sang : > >> I am getting more and more patches for TMIO. >> I put all in a single series to clarify the patch order. > > Hmmm, that makes reviewing harder in my opinion. I think this depends on people. You are the maintainer of TMIO MMC, so I will

Re: [PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-11-27 Thread Wolfram Sang
> I am getting more and more patches for TMIO. > I put all in a single series to clarify the patch order. Hmmm, that makes reviewing harder in my opinion. I really liked the small serieses which could be improved, acked, and applied. This big one will take much longer to review and resending wil

[PATCH v2 00/22] mmc: tmio: various fixes and cleanups

2017-11-24 Thread Masahiro Yamada
I am working on this IP for Socionext SoCs. I was hit by several issues, and noticed various clean-up candidates. - Fix and clean-up Kconfig - Fix various card detection problems - Move Renesas private data out of TMIO core - Allow to perform platform-specific settings before MMC host starts