Re: [PATCH v2 00/15] slab: overload struct slab over struct page to reduce memory usage

2013-10-19 Thread Andi Kleen
Joonsoo Kim writes: > There is two main topics in this patchset. One is to reduce memory usage > and the other is to change a management method of free objects of a slab. I did a quick read over the whole patchset and it looks good to me. I especially like how much code you remove. And of course

Re: [PATCH v2 00/15] slab: overload struct slab over struct page to reduce memory usage

2013-10-19 Thread Andi Kleen
Andrew Morton writes: > > One example is mm/memory-failure.c:memory_failure(). It starts with a > raw pfn, uses that to get at the `struct page', then starts playing > around with it. Will that code still work correctly when some of the > page's fields have been overlayed with slab-specific cont

Re: [PATCH v2 00/15] slab: overload struct slab over struct page to reduce memory usage

2013-10-17 Thread Christoph Lameter
On Wed, 16 Oct 2013, Andrew Morton wrote: > This issue hasn't been well thought through. Given a random struct > page, there isn't any protocol to determine what it actually *is*. > It's a plain old variant record, but it lacks the agreed-upon tag field > which tells users which variant is curren

Re: [PATCH v2 00/15] slab: overload struct slab over struct page to reduce memory usage

2013-10-17 Thread Christoph Lameter
On Thu, 17 Oct 2013, Pekka Enberg wrote: > On 10/16/13 10:34 PM, Andrew Morton wrote: > > On Wed, 16 Oct 2013 17:43:57 +0900 Joonsoo Kim > > wrote: > > > > > There is two main topics in this patchset. One is to reduce memory usage > > > and the other is to change a management method of free objec

Re: [PATCH v2 00/15] slab: overload struct slab over struct page to reduce memory usage

2013-10-17 Thread Pekka Enberg
On 10/16/13 10:34 PM, Andrew Morton wrote: On Wed, 16 Oct 2013 17:43:57 +0900 Joonsoo Kim wrote: There is two main topics in this patchset. One is to reduce memory usage and the other is to change a management method of free objects of a slab. The SLAB allocate a struct slab for each slab. Th

Re: [PATCH v2 00/15] slab: overload struct slab over struct page to reduce memory usage

2013-10-16 Thread Joonsoo Kim
On Wed, Oct 16, 2013 at 01:34:57PM -0700, Andrew Morton wrote: > On Wed, 16 Oct 2013 17:43:57 +0900 Joonsoo Kim wrote: > > > There is two main topics in this patchset. One is to reduce memory usage > > and the other is to change a management method of free objects of a slab. > > > > The SLAB all

Re: [PATCH v2 00/15] slab: overload struct slab over struct page to reduce memory usage

2013-10-16 Thread Andrew Morton
On Wed, 16 Oct 2013 17:43:57 +0900 Joonsoo Kim wrote: > There is two main topics in this patchset. One is to reduce memory usage > and the other is to change a management method of free objects of a slab. > > The SLAB allocate a struct slab for each slab. The size of this structure > except bufc

[PATCH v2 00/15] slab: overload struct slab over struct page to reduce memory usage

2013-10-16 Thread Joonsoo Kim
There is two main topics in this patchset. One is to reduce memory usage and the other is to change a management method of free objects of a slab. The SLAB allocate a struct slab for each slab. The size of this structure except bufctl array is 40 bytes on 64 bits machine. We can reduce memory wast