Re: [PATCH v2 00/11] test_user_copy improvements

2015-08-12 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 11 Aug 2015 13:20:53 +0200 > On Tue, Aug 11, 2015 at 6:08 AM, David Miller wrote: ... >> diff --git a/lib/Kconfig b/lib/Kconfig >> index 3a2ef67..149eb29 100644 >> --- a/lib/Kconfig >> +++ b/lib/Kconfig >> @@ -62,6 +62,9 @@ config ARCH_USE_CMPXCHG_LOCKREF >>

Re: [PATCH v2 00/11] test_user_copy improvements

2015-08-11 Thread David Miller
From: James Hogan Date: Tue, 11 Aug 2015 12:07:20 +0100 > Out of interest, is the zeroing a strict requirement for correct use, or > a safety precaution to prevent data leakage in case of bad error checking? > > (A quick look reveals that for copy_from_user() when access_ok() fails, > only arm,

Re: [PATCH v2 00/11] test_user_copy improvements

2015-08-11 Thread Geert Uytterhoeven
On Tue, Aug 11, 2015 at 6:08 AM, David Miller wrote: > From: David Miller > Date: Mon, 10 Aug 2015 15:29:38 -0700 (PDT) > >> Also, I think the tests you added and protected with MIPS ifdefs could >> equally be enabled on sparc64. > > James, as per this issue, I was thinking we could do something

Re: [PATCH v2 00/11] test_user_copy improvements

2015-08-11 Thread James Hogan
Hi David, On 10/08/15 23:29, David Miller wrote: > From: James Hogan > Date: Fri, 7 Aug 2015 16:21:53 +0100 > >> These patches extend the test_user_copy test module to handle lots more >> cases of user accessors which architectures can override separately, and >> in particular those which are im

Re: [PATCH v2 00/11] test_user_copy improvements

2015-08-10 Thread David Miller
From: David Miller Date: Mon, 10 Aug 2015 15:29:38 -0700 (PDT) > Also, I think the tests you added and protected with MIPS ifdefs could > equally be enabled on sparc64. James, as per this issue, I was thinking we could do something like this so that the tests don't get messy: diff --git a/arch/

Re: [PATCH v2 00/11] test_user_copy improvements

2015-08-10 Thread David Miller
From: James Hogan Date: Fri, 7 Aug 2015 16:21:53 +0100 > These patches extend the test_user_copy test module to handle lots more > cases of user accessors which architectures can override separately, and > in particular those which are important for checking the MIPS Enhanced > Virtual Addressing

Re: [PATCH v2 00/11] test_user_copy improvements

2015-08-07 Thread Kees Cook
On Fri, Aug 7, 2015 at 8:21 AM, James Hogan wrote: > These patches extend the test_user_copy test module to handle lots more > cases of user accessors which architectures can override separately, and > in particular those which are important for checking the MIPS Enhanced > Virtual Addressing (EVA

[PATCH v2 00/11] test_user_copy improvements

2015-08-07 Thread James Hogan
These patches extend the test_user_copy test module to handle lots more cases of user accessors which architectures can override separately, and in particular those which are important for checking the MIPS Enhanced Virtual Addressing (EVA) implementations, which need to handle overlapping user and