Re: [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support

2014-10-02 Thread Matt Fleming
On Thu, 02 Oct, at 05:04:54PM, Andi Kleen wrote: > > Yes, we should just get rid of Kconfig and give everyone > the same kernel like Windows. Much simpler for everyone, > wouldn't it be? > > I'm sure you can easily see the flaws in the argument. No, not really, since that's not the argument I m

Re: [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support

2014-10-02 Thread Andi Kleen
> I didn't include support for that because none of the other x86 pmu > drivers are buildable as modules. Is there a reason for that? Not done yet. Uncore drivers are definitely on the list. > It's much simpler to just build it in and enable it based on > CONFIG_PERF_EVENTS + CONFIG_INTEL_CPU.

Re: [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support

2014-10-02 Thread Peter Zijlstra
On Thu, Oct 02, 2014 at 07:51:24AM +0100, Matt Fleming wrote: > On Wed, 01 Oct, at 02:42:05PM, Andi Kleen wrote: > > Matt Fleming writes: > > > > > > Changes in v2: > > > > > > - Added Jiri Olsa's Acked-by to PATCH 02/11. > > > > > > - Use x86_match_cpu() in intel_cqm_init() and make sure we gra

Re: [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support

2014-10-01 Thread Matt Fleming
On Wed, 01 Oct, at 02:42:05PM, Andi Kleen wrote: > Matt Fleming writes: > > > > Changes in v2: > > > > - Added Jiri Olsa's Acked-by to PATCH 02/11. > > > > - Use x86_match_cpu() in intel_cqm_init() and make sure we grab the > >hotplug lock to prevent races as pointed out by Andi Kleen in > >

Re: [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support

2014-10-01 Thread Andi Kleen
Matt Fleming writes: > > Changes in v2: > > - Added Jiri Olsa's Acked-by to PATCH 02/11. > > - Use x86_match_cpu() in intel_cqm_init() and make sure we grab the >hotplug lock to prevent races as pointed out by Andi Kleen in >PATCH 08/11. > > - Delete a stale comment in commit message of

[PATCH v2 00/11] perf: Intel Cache QoS Monitoring support

2014-10-01 Thread Matt Fleming
From: Matt Fleming This patch series adds a new PMU driver for the Intel Cache Monitoring hardware feature available in Intel Xeon processors, which allows monitoring of LLC occupancy on a task, group or system-wide basis. The first few patches modify tools/perf to handle per-package counters, w