Re: [PATCH v2 0/8] exec: Control flow simplifications

2020-05-21 Thread Eric W. Biederman
Kees Cook writes: > On Wed, May 20, 2020 at 05:12:10PM -0500, Eric W. Biederman wrote: >> >> I have pushed this out to: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git >> exec-next >> >> I have collected up the acks and reviewed-by's, and fixed a couple of >> t

Re: [PATCH v2 0/8] exec: Control flow simplifications

2020-05-20 Thread Kees Cook
On Wed, May 20, 2020 at 05:12:10PM -0500, Eric W. Biederman wrote: > > I have pushed this out to: > > git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > exec-next > > I have collected up the acks and reviewed-by's, and fixed a couple of > typos but that is it. Awesome!

Re: [PATCH v2 0/8] exec: Control flow simplifications

2020-05-20 Thread Eric W. Biederman
I have pushed this out to: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git exec-next I have collected up the acks and reviewed-by's, and fixed a couple of typos but that is it. If we need comment fixes or additional cleanups we can apply that on top of this series.

Re: [PATCH v2 0/8] exec: Control flow simplifications

2020-05-20 Thread Eric W. Biederman
Kees Cook writes: > On Mon, May 18, 2020 at 07:29:00PM -0500, Eric W. Biederman wrote: >> arch/alpha/kernel/binfmt_loader.c | 11 + >> fs/binfmt_elf.c| 4 +- >> fs/binfmt_elf_fdpic.c | 4 +- >> fs/binfmt_em86.c | 13 + >> fs/binfmt_mi

Re: [PATCH v2 0/8] exec: Control flow simplifications

2020-05-19 Thread Kees Cook
On Mon, May 18, 2020 at 07:29:00PM -0500, Eric W. Biederman wrote: > arch/alpha/kernel/binfmt_loader.c | 11 + > fs/binfmt_elf.c| 4 +- > fs/binfmt_elf_fdpic.c | 4 +- > fs/binfmt_em86.c | 13 + > fs/binfmt_misc.c | 69

Re: [PATCH v2 0/8] exec: Control flow simplifications

2020-05-18 Thread Linus Torvalds
On Mon, May 18, 2020 at 5:32 PM Eric W. Biederman wrote: > > It is hard to follow the control flow in exec.c as the code has evolved over > time and something that used to work one way now works another. This set of > changes attempts to address the worst of that, to remove unnecessary work > and

[PATCH v2 0/8] exec: Control flow simplifications

2020-05-18 Thread Eric W. Biederman
It is hard to follow the control flow in exec.c as the code has evolved over time and something that used to work one way now works another. This set of changes attempts to address the worst of that, to remove unnecessary work and to make the code a little easier to follow. The churn is a bit h