Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-24 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 23, 2014 at 03:41:39PM +0400, Stanislav Fomichev escreveu: > > > But we then need to predefine many probes for decoding to work in the > > > form of > > > func:offset, and then play catch-up with all the kernel changes. > > > Or I miss something important here? > > No you don't. > >

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-24 Thread Namhyung Kim
Hi Arnaldo and Stanislav, On Fri, 20 Jun 2014 10:21:05 -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 20, 2014 at 02:49:42PM +0400, Stanislav Fomichev escreveu: >> This patch series adds support for pagefaults tracing to 'perf trace' >> command. >> It seems this feature was planned by Namhy

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-23 Thread David Ahern
On 6/20/14, 9:24 AM, Arnaldo Carvalho de Melo wrote: Right now it is too simple, but I was starting to work (when you jumped right in with your work making me stop and go on testing/reviewing :) ) on making it more generic so that we could defer pretty printing the arguments from sys_enter to sys

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-23 Thread Stanislav Fomichev
> > But we then need to predefine many probes for decoding to work in the form > > of > > func:offset, and then play catch-up with all the kernel changes. > > Or I miss something important here? > > No you don't. > > If we want to disturb the system in the least way possible, we need to > tag al

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-20 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 20, 2014 at 08:18:59PM +0400, Stanislav Fomichev escreveu: > > Hey, haven't you seen the vfs_getname probe? Idea is to hook on where > > the relevant copy_from_user is done and insert that into the ring > > buffer, as we already do for mapping fd -> pathname. > I saw it but didn't actu

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-20 Thread Stanislav Fomichev
> Hey, haven't you seen the vfs_getname probe? Idea is to hook on where > the relevant copy_from_user is done and insert that into the ring > buffer, as we already do for mapping fd -> pathname. I saw it but didn't actually try because it needs all the debugging stuff enabled and in place. > I.e.

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-20 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 20, 2014 at 07:03:18PM +0400, Stanislav Fomichev escreveu: > > Just to clarify here, those slides came from slides I made and in turn > > the whole idea about pagefaults tracing I got from the trace prototype > > that Thomas Gleixner implemented in his 'trace' utility, described > > he

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-20 Thread Stanislav Fomichev
> Just to clarify here, those slides came from slides I made and in turn > the whole idea about pagefaults tracing I got from the trace prototype > that Thomas Gleixner implemented in his 'trace' utility, described > here: > > Announcing a new utility: 'trace' > http://lwn.net/Articles/415728

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-20 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 20, 2014 at 02:49:42PM +0400, Stanislav Fomichev escreveu: > This patch series adds support for pagefaults tracing to 'perf trace' command. > It seems this feature was planned by Namhyung Kim > (http://events.linuxfoundation.org/images/stories/pdf/klf2012_n_kim.pdf page > 17/28) > but

[PATCH v2 0/7] perf trace pagefaults

2014-06-20 Thread Stanislav Fomichev
This patch series adds support for pagefaults tracing to 'perf trace' command. It seems this feature was planned by Namhyung Kim (http://events.linuxfoundation.org/images/stories/pdf/klf2012_n_kim.pdf page 17/28) but I couldn't find any prior patches/discussion and started from scratch. First th