Re: [STLinux Kernel] [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-30 Thread Maxime Coquelin
On 09/30/2015 04:28 PM, Herbert Xu wrote: On Wed, Sep 30, 2015 at 03:15:39PM +0100, Lee Jones wrote: I prefer not to merge patches that cannot be tested. Without the DT bits in patch 6 the other five patches are useless. So I think patch 6 should be applied together with the other five which

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-30 Thread Lee Jones
On Wed, 30 Sep 2015, Herbert Xu wrote: > On Wed, Sep 30, 2015 at 03:15:39PM +0100, Lee Jones wrote: > > > > > I prefer not to merge patches that cannot be tested. Without > > > the DT bits in patch 6 the other five patches are useless. So > > > I think patch 6 should be applied together with the

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-30 Thread Herbert Xu
On Wed, Sep 30, 2015 at 03:15:39PM +0100, Lee Jones wrote: > > > I prefer not to merge patches that cannot be tested. Without > > the DT bits in patch 6 the other five patches are useless. So > > I think patch 6 should be applied together with the other five > > which add the driver. > > That's

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-30 Thread Lee Jones
On Wed, 30 Sep 2015, Herbert Xu wrote: > On Tue, Sep 29, 2015 at 03:29:32PM +0100, Lee Jones wrote: > > > > I see that your tree is 8 days old, so this may have been resolved > > already, but would you be kind enough to ensure you remove the 6th > > (ARM) patch from your repo please? I wouldn't w

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-30 Thread Herbert Xu
On Tue, Sep 29, 2015 at 03:29:32PM +0100, Lee Jones wrote: > > I see that your tree is 8 days old, so this may have been resolved > already, but would you be kind enough to ensure you remove the 6th > (ARM) patch from your repo please? I wouldn't want it to cause > conflicts and for Maxime and yo

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-29 Thread Lee Jones
On Fri, 18 Sep 2015, Lee Jones wrote: > On Fri, 18 Sep 2015, Herbert Xu wrote: > > On Fri, Sep 18, 2015 at 03:53:50PM +0100, Lee Jones wrote: > > > On 18 September 2015 at 15:07, Herbert Xu > > > wrote: > > > > On Thu, Sep 17, 2015 at 02:45:50PM +0100, Lee Jones wrote: > > > >> v1 => v2: > > > >>

Re: [STLinux Kernel] [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-29 Thread Lee Jones
On Tue, 29 Sep 2015, Peter Griffin wrote: > On Thu, 17 Sep 2015, Lee Jones wrote: > > > v1 => v2: > > - New patch: Also fixing /dev/hw_random => /dev/hwrng in Kconfig > > - Fix 2099 => 2009 typo in commit log > > - Fix 'number of random numbers sourced' return value > > - Treat devm_clk_get()'

Re: [STLinux Kernel] [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-29 Thread Peter Griffin
Hi Lee, On Thu, 17 Sep 2015, Lee Jones wrote: > v1 => v2: > - New patch: Also fixing /dev/hw_random => /dev/hwrng in Kconfig > - Fix 2099 => 2009 typo in commit log > - Fix 'number of random numbers sourced' return value > - Treat devm_clk_get()'s return value correctly > - Check return valu

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-19 Thread Lee Jones
On Sun, 20 Sep 2015, Herbert Xu wrote: > On Sat, Sep 19, 2015 at 10:21:45AM +0100, Lee Jones wrote: > > > > That's not how it works. It's helpful, more often than not, to submit > > the entire set to each maintainer concerned so they can keep up with > > the general conversation. By only sending

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-19 Thread Herbert Xu
On Sat, Sep 19, 2015 at 10:21:45AM +0100, Lee Jones wrote: > > That's not how it works. It's helpful, more often than not, to submit > the entire set to each maintainer concerned so they can keep up with > the general conversation. By only sending specific patches to > maintainers you essentially

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-19 Thread Lee Jones
On Sat, 19 Sep 2015, Herbert Xu wrote: > On Fri, Sep 18, 2015 at 04:51:12PM +0100, Lee Jones wrote: > > > > I think it's okay for you to take all but patch 6. > > > > Patch 6 is an ARM patch and needs to go into ARM SoC via > > STMicroelectronics STi tree. > > In future please don't send me patch

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-18 Thread Herbert Xu
On Fri, Sep 18, 2015 at 04:51:12PM +0100, Lee Jones wrote: > > I think it's okay for you to take all but patch 6. > > Patch 6 is an ARM patch and needs to go into ARM SoC via > STMicroelectronics STi tree. In future please don't send me patches that you don't want me to merge in the series. Chee

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-18 Thread Lee Jones
On Fri, 18 Sep 2015, Herbert Xu wrote: > On Fri, Sep 18, 2015 at 03:53:50PM +0100, Lee Jones wrote: > > On 18 September 2015 at 15:07, Herbert Xu > > wrote: > > > On Thu, Sep 17, 2015 at 02:45:50PM +0100, Lee Jones wrote: > > >> v1 => v2: > > >> - New patch: Also fixing /dev/hw_random => /dev/hw

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-18 Thread Herbert Xu
On Fri, Sep 18, 2015 at 03:53:50PM +0100, Lee Jones wrote: > On 18 September 2015 at 15:07, Herbert Xu wrote: > > On Thu, Sep 17, 2015 at 02:45:50PM +0100, Lee Jones wrote: > >> v1 => v2: > >> - New patch: Also fixing /dev/hw_random => /dev/hwrng in Kconfig > >> - Fix 2099 => 2009 typo in commit

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-18 Thread Lee Jones
On 18 September 2015 at 15:07, Herbert Xu wrote: > On Thu, Sep 17, 2015 at 02:45:50PM +0100, Lee Jones wrote: >> v1 => v2: >> - New patch: Also fixing /dev/hw_random => /dev/hwrng in Kconfig >> - Fix 2099 => 2009 typo in commit log >> - Fix 'number of random numbers sourced' return value >> -

Re: [PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-18 Thread Herbert Xu
On Thu, Sep 17, 2015 at 02:45:50PM +0100, Lee Jones wrote: > v1 => v2: > - New patch: Also fixing /dev/hw_random => /dev/hwrng in Kconfig > - Fix 2099 => 2009 typo in commit log > - Fix 'number of random numbers sourced' return value > - Treat devm_clk_get()'s return value correctly > - Check

[PATCH v2 0/7] hwrng: Add support for STMicroelectronics' RNG IP

2015-09-17 Thread Lee Jones
v1 => v2: - New patch: Also fixing /dev/hw_random => /dev/hwrng in Kconfig - Fix 2099 => 2009 typo in commit log - Fix 'number of random numbers sourced' return value - Treat devm_clk_get()'s return value correctly - Check return value of clk_prepare_enable() - Use sysfs_streq() instead of ma