Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 5:36 PM Arvind Sankar wrote: > > On Tue, May 26, 2020 at 04:50:38PM +0200, Sedat Dilek wrote: > > On Tue, May 26, 2020 at 4:47 PM Arvind Sankar wrote: > > > > > > On Tue, May 26, 2020 at 02:44:29PM +0200, Sedat Dilek wrote: > > > > > > > > Are those diffs correct when usin

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 5:31 PM Arvind Sankar wrote: > > On Tue, May 26, 2020 at 05:07:24PM +0200, Sedat Dilek wrote: > > > > > > > > > > Maybe this should be: > > > > > > [ arch/x86/boot/compressed/Makefile ] > > > > > > -KBUILD_CFLAGS += -include hidden.h > > > +KBUILD_CFLAGS += -include ./hidde

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 5:07 PM Sedat Dilek wrote: ... > > > patchset to previous build: > > > > > > $ git log --no-merges --oneline > > > 5.7.0-rc7-1-amd64-clang..5.7.0-rc7-2-amd64-clang > > > 8b74901cb9e5 > > > (for-5.7/x86-boot-remove-runtime-relocations-from-compressed-kernel-v2-nivedita76

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 5:36 PM Arvind Sankar wrote: > > On Tue, May 26, 2020 at 04:50:38PM +0200, Sedat Dilek wrote: > > On Tue, May 26, 2020 at 4:47 PM Arvind Sankar wrote: > > > > > > On Tue, May 26, 2020 at 02:44:29PM +0200, Sedat Dilek wrote: > > > > > > > > Are those diffs correct when usin

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Arvind Sankar
On Tue, May 26, 2020 at 04:50:38PM +0200, Sedat Dilek wrote: > On Tue, May 26, 2020 at 4:47 PM Arvind Sankar wrote: > > > > On Tue, May 26, 2020 at 02:44:29PM +0200, Sedat Dilek wrote: > > > > > > Are those diffs correct when using "x86/boot: Correct relocation > > > destination on old linkers"? >

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Arvind Sankar
On Tue, May 26, 2020 at 05:07:24PM +0200, Sedat Dilek wrote: > > > > > > > Maybe this should be: > > > > [ arch/x86/boot/compressed/Makefile ] > > > > -KBUILD_CFLAGS += -include hidden.h > > +KBUILD_CFLAGS += -include ./hidden.h > > > > NOPE. > > This works: > > [ arch/x86/boot/compressed/Makefi

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 4:55 PM Sedat Dilek wrote: > > On Tue, May 26, 2020 at 4:48 PM Sedat Dilek wrote: > > > > On Tue, May 26, 2020 at 2:44 PM Sedat Dilek wrote: > > > > > > On Tue, May 26, 2020 at 2:33 PM Sedat Dilek wrote: > > > > > > > > On Tue, May 26, 2020 at 2:30 PM Ard Biesheuvel wro

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 4:48 PM Sedat Dilek wrote: > > On Tue, May 26, 2020 at 2:44 PM Sedat Dilek wrote: > > > > On Tue, May 26, 2020 at 2:33 PM Sedat Dilek wrote: > > > > > > On Tue, May 26, 2020 at 2:30 PM Ard Biesheuvel wrote: > > > > > > > > On Tue, 26 May 2020 at 14:29, Sedat Dilek wrote

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 4:47 PM Arvind Sankar wrote: > > On Tue, May 26, 2020 at 02:44:29PM +0200, Sedat Dilek wrote: > > > > Are those diffs correct when using "x86/boot: Correct relocation > > destination on old linkers"? > > > > It looks ok, but that patch (and even marking the other symbols .h

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 2:44 PM Sedat Dilek wrote: > > On Tue, May 26, 2020 at 2:33 PM Sedat Dilek wrote: > > > > On Tue, May 26, 2020 at 2:30 PM Ard Biesheuvel wrote: > > > > > > On Tue, 26 May 2020 at 14:29, Sedat Dilek wrote: > > > > > > > > On Tue, May 26, 2020 at 12:59 AM Arvind Sankar >

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Arvind Sankar
On Tue, May 26, 2020 at 02:44:29PM +0200, Sedat Dilek wrote: > > Are those diffs correct when using "x86/boot: Correct relocation > destination on old linkers"? > It looks ok, but that patch (and even marking the other symbols .hidden) should be unnecessary after this series.

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 2:33 PM Sedat Dilek wrote: > > On Tue, May 26, 2020 at 2:30 PM Ard Biesheuvel wrote: > > > > On Tue, 26 May 2020 at 14:29, Sedat Dilek wrote: > > > > > > On Tue, May 26, 2020 at 12:59 AM Arvind Sankar > > > wrote: > > > > > > > > The compressed kernel currently contains

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 2:30 PM Ard Biesheuvel wrote: > > On Tue, 26 May 2020 at 14:29, Sedat Dilek wrote: > > > > On Tue, May 26, 2020 at 12:59 AM Arvind Sankar > > wrote: > > > > > > The compressed kernel currently contains bogus runtime relocations in > > > the startup code in head_{32,64}.S

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Ard Biesheuvel
On Tue, 26 May 2020 at 14:29, Sedat Dilek wrote: > > On Tue, May 26, 2020 at 12:59 AM Arvind Sankar wrote: > > > > The compressed kernel currently contains bogus runtime relocations in > > the startup code in head_{32,64}.S, which are generated by the linker, > > but must not actually be processe

Re: [PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-26 Thread Sedat Dilek
On Tue, May 26, 2020 at 12:59 AM Arvind Sankar wrote: > > The compressed kernel currently contains bogus runtime relocations in > the startup code in head_{32,64}.S, which are generated by the linker, > but must not actually be processed at runtime. > > This generates warnings when linking with th

[PATCH v2 0/4] x86/boot: Remove runtime relocations from compressed kernel

2020-05-25 Thread Arvind Sankar
The compressed kernel currently contains bogus runtime relocations in the startup code in head_{32,64}.S, which are generated by the linker, but must not actually be processed at runtime. This generates warnings when linking with the BFD linker, and errors with LLD, which defaults to erroring on r