Re: [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency

2016-01-05 Thread Baolin Wang
On 5 January 2016 at 04:13, Mark Brown wrote: > On Sat, Jan 02, 2016 at 11:46:08PM +0100, Milan Broz wrote: > >> Anyway, I think that you should optimize driver, not add strange hw-dependent >> crypto modes to dmcrypt. This is not the first crypto accelerator that is >> just not >> suited for thi

Re: [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency

2016-01-04 Thread Mark Brown
On Sat, Jan 02, 2016 at 11:46:08PM +0100, Milan Broz wrote: > Anyway, I think that you should optimize driver, not add strange hw-dependent > crypto modes to dmcrypt. This is not the first crypto accelerator that is > just not > suited for this kind of use. > (If it can process batch of chunks o

Re: [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency

2016-01-03 Thread Baolin Wang
Hi Milan, On 3 January 2016 at 06:46, Milan Broz wrote: > > Sorry for delay, I tried to compile it. > It doesn't crash now, but it also does not work. > > You usage of IV in XTS mode is not correct - it cannot just work this way, > you have to initialize IV after each block. And just one write no

Re: [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency

2016-01-02 Thread Milan Broz
On 12/17/2015 08:37 AM, Baolin Wang wrote: > Hi Milan, > > On 16 December 2015 at 16:08, Milan Broz wrote: >> On 12/16/2015 04:18 AM, Baolin Wang wrote: >>> From the dm-crypt performance report, we found it shows low efficiency >>> with crypto engine for some mode (like ecb or xts mode). Because

Re: [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency

2015-12-16 Thread Baolin Wang
Hi Milan, On 16 December 2015 at 16:08, Milan Broz wrote: > On 12/16/2015 04:18 AM, Baolin Wang wrote: >> From the dm-crypt performance report, we found it shows low efficiency >> with crypto engine for some mode (like ecb or xts mode). Because in dm >> crypt, it will map the IO data buffer with

Re: [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency

2015-12-16 Thread Baolin Wang
On 16 December 2015 at 16:08, Milan Broz wrote: > On 12/16/2015 04:18 AM, Baolin Wang wrote: >> From the dm-crypt performance report, we found it shows low efficiency >> with crypto engine for some mode (like ecb or xts mode). Because in dm >> crypt, it will map the IO data buffer with scatterlist

Re: [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency

2015-12-16 Thread Milan Broz
On 12/16/2015 04:18 AM, Baolin Wang wrote: > From the dm-crypt performance report, we found it shows low efficiency > with crypto engine for some mode (like ecb or xts mode). Because in dm > crypt, it will map the IO data buffer with scatterlist, and send the > scatterlist of one bio to the encrypt

[PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency

2015-12-15 Thread Baolin Wang
>From the dm-crypt performance report, we found it shows low efficiency with crypto engine for some mode (like ecb or xts mode). Because in dm crypt, it will map the IO data buffer with scatterlist, and send the scatterlist of one bio to the encryption engine, if send more scatterlists with bigger