Re: [PATCH v2] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-18 Thread Gi-Oh Kim
On Wed, Dec 5, 2018 at 8:11 AM Zhenzhong Duan wrote: > > > On 2018/12/5 14:27, Masahiro Yamada wrote: > > It is troublesome to add a diagnostic like this to the Makefile > > parse stage because the top-level Makefile could be parsed with > > a stale include/config/auto.conf. > > > > Once you are h

Re: [PATCH v2] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Zhenzhong Duan
On 2018/12/5 14:27, Masahiro Yamada wrote: It is troublesome to add a diagnostic like this to the Makefile parse stage because the top-level Makefile could be parsed with a stale include/config/auto.conf. Once you are hit by the error about non-retpoline compiler, the compilation still breaks

Re: [PATCH v2] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Meelis Roos
05.12.18 08:27 Masahiro Yamada kirjutas: The easiest fix is to move this check to the "archprepare" like commit 829fe4aa9ac1 ("x86: Allow generating user-space headers without a compiler") did. Link: https://lkml.org/lkml/2018/12/4/206 Fixes: 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE d

[PATCH v2] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Masahiro Yamada
It is troublesome to add a diagnostic like this to the Makefile parse stage because the top-level Makefile could be parsed with a stale include/config/auto.conf. Once you are hit by the error about non-retpoline compiler, the compilation still breaks even after disabling CONFIG_RETPOLINE. The eas