Re: [PATCH v2] x86/apic: Move pending intr check code into it's own function

Hi Dou, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/auto-latest] [also build test ERROR on v4.16-rc2 next-20180223] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: htt

Re: [PATCH v2] x86/apic: Move pending intr check code into it's own function

Hi Dou, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/auto-latest] [also build test ERROR on v4.16-rc2 next-20180223] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: htt

Re: [PATCH v2] x86/apic: Move pending intr check code into it's own function

* Dou Liyang wrote: > the pending interrupt check code is mixed with the local APIC setup code, > that looks messy. > > Extract the related code, move it into a new function named > apic_pending_intr_clear(). > > bonus cleanups from Andy Shevchenko's suggestions: > > - for() -> for_each_set

[PATCH v2] x86/apic: Move pending intr check code into it's own function

the pending interrupt check code is mixed with the local APIC setup code, that looks messy. Extract the related code, move it into a new function named apic_pending_intr_clear(). bonus cleanups from Andy Shevchenko's suggestions: - for() -> for_each_set_bit() - printk() -> pr_err() Signed-o