Re: [PATCH v2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-21 Thread Enric Balletbo Serra
2016-07-21 15:24 GMT+02:00 Guenter Roeck : > On 07/21/2016 01:59 AM, Enric Balletbo Serra wrote: > > [ ... ] > +static ssize_t ziirave_wdt_sysfs_store_firm(struct device *dev, + struct device_attribute *attr, +

Re: [PATCH v2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-21 Thread Guenter Roeck
On 07/21/2016 01:59 AM, Enric Balletbo Serra wrote: [ ... ] +static ssize_t ziirave_wdt_sysfs_store_firm(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct i

Re: [PATCH v2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-21 Thread Enric Balletbo Serra
Correction 2016-07-21 10:59 GMT+02:00 Enric Balletbo Serra : > Hi Guenter, > > Many thanks for the review, I'm agree with your comments so I'll apply > the changes in next version that hopefully I'll send soon. Just some > questions below. > > 2016-07-21 5:42 GMT+02:00 Guenter Roeck : >> On 07/20/

Re: [PATCH v2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-21 Thread Enric Balletbo Serra
Hi Guenter, Many thanks for the review, I'm agree with your comments so I'll apply the changes in next version that hopefully I'll send soon. Just some questions below. 2016-07-21 5:42 GMT+02:00 Guenter Roeck : > On 07/20/2016 03:31 AM, Enric Balletbo i Serra wrote: >> >> This patch adds and entr

Re: [PATCH v2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-20 Thread Guenter Roeck
On 07/20/2016 03:31 AM, Enric Balletbo i Serra wrote: This patch adds and entry to the sysfs to start firmware upload process on the specified device with the requested firmware. The uploading of the firmware needs only to happen once per firmware upgrade, as the firmware is stored in persistent

[PATCH v2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-20 Thread Enric Balletbo i Serra
This patch adds and entry to the sysfs to start firmware upload process on the specified device with the requested firmware. The uploading of the firmware needs only to happen once per firmware upgrade, as the firmware is stored in persistent storage. If the firmware upload or the firmware verific