Re: [PATCH v2] watchdog: add driver for the MEN 16z069 IP-Core

2018-07-31 Thread Guenter Roeck
On 07/31/2018 06:57 AM, Johannes Thumshirn wrote: On Mon, Jul 16, 2018 at 09:25:10AM +0200, Johannes Thumshirn wrote: Add a driver for the MEN 16z069 Watchdog and Reset Controller IP-Core. Signed-off-by: Johannes Thumshirn Wim, Any comments about this driver? The merge window is about to ope

Re: [PATCH v2] watchdog: add driver for the MEN 16z069 IP-Core

2018-07-31 Thread Johannes Thumshirn
On Mon, Jul 16, 2018 at 09:25:10AM +0200, Johannes Thumshirn wrote: > Add a driver for the MEN 16z069 Watchdog and Reset Controller IP-Core. > > Signed-off-by: Johannes Thumshirn Wim, Any comments about this driver? The merge window is about to open and I haven't heard any statement from you if

Re: [PATCH v2] watchdog: add driver for the MEN 16z069 IP-Core

2018-07-17 Thread Michael Moese
On Mon, Jul 16, 2018 at 09:25:10AM +0200, Johannes Thumshirn wrote: > Add a driver for the MEN 16z069 Watchdog and Reset Controller IP-Core. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Michael Moese > > --- > Changes to v1: > * Sorted includes alphabetically > * Indented defines with t

Re: [PATCH v2] watchdog: add driver for the MEN 16z069 IP-Core

2018-07-17 Thread Guenter Roeck
On 07/16/2018 12:25 AM, Johannes Thumshirn wrote: Add a driver for the MEN 16z069 Watchdog and Reset Controller IP-Core. Signed-off-by: Johannes Thumshirn Reviewed-by: Guenter Roeck --- Changes to v1: * Sorted includes alphabetically * Indented defines with tabs * Removed unnecessary time

[PATCH v2] watchdog: add driver for the MEN 16z069 IP-Core

2018-07-16 Thread Johannes Thumshirn
Add a driver for the MEN 16z069 Watchdog and Reset Controller IP-Core. Signed-off-by: Johannes Thumshirn --- Changes to v1: * Sorted includes alphabetically * Indented defines with tabs * Removed unnecessary timeout validation * Removed unnecessary masking of values * Fixed error return in .prob