Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-05 Thread Stefano Garzarella
On Wed, Apr 02, 2025 at 12:14:24PM -0400, Stefan Hajnoczi wrote: On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: Ever since the introduction of the virtio vsock driver, it included pushback logic that blocks it from taking any new RX packets until the TX queue backlog becomes sha

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-05 Thread Stefan Hajnoczi
On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: > Ever since the introduction of the virtio vsock driver, it included > pushback logic that blocks it from taking any new RX packets until the > TX queue backlog becomes shallower than the virtqueue size. > > This logic works fine whe

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-04 Thread Michael S. Tsirkin
On Wed, Apr 02, 2025 at 12:14:24PM -0400, Stefan Hajnoczi wrote: > On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: > > Ever since the introduction of the virtio vsock driver, it included > > pushback logic that blocks it from taking any new RX packets until the > > TX queue backlog

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-04 Thread Simon Horman
On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: > Ever since the introduction of the virtio vsock driver, it included > pushback logic that blocks it from taking any new RX packets until the > TX queue backlog becomes shallower than the virtqueue size. > > This logic works fine whe

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-04 Thread Michael S. Tsirkin
On Fri, Apr 04, 2025 at 10:30:43AM +0200, Stefano Garzarella wrote: > On Fri, Apr 04, 2025 at 04:14:51AM -0400, Michael S. Tsirkin wrote: > > On Fri, Apr 04, 2025 at 10:04:38AM +0200, Alexander Graf wrote: > > > > > > On 03.04.25 14:21, Michael S. Tsirkin wrote: > > > > On Wed, Apr 02, 2025 at 12:

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-04 Thread Stefano Garzarella
On Fri, Apr 04, 2025 at 04:14:51AM -0400, Michael S. Tsirkin wrote: On Fri, Apr 04, 2025 at 10:04:38AM +0200, Alexander Graf wrote: On 03.04.25 14:21, Michael S. Tsirkin wrote: > On Wed, Apr 02, 2025 at 12:14:24PM -0400, Stefan Hajnoczi wrote: > > On Tue, Apr 01, 2025 at 08:13:49PM +, Alexa

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-04 Thread Michael S. Tsirkin
On Fri, Apr 04, 2025 at 10:04:38AM +0200, Alexander Graf wrote: > > On 03.04.25 14:21, Michael S. Tsirkin wrote: > > On Wed, Apr 02, 2025 at 12:14:24PM -0400, Stefan Hajnoczi wrote: > > > On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: > > > > Ever since the introduction of the vir

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-04 Thread Alexander Graf
On 03.04.25 14:21, Michael S. Tsirkin wrote: On Wed, Apr 02, 2025 at 12:14:24PM -0400, Stefan Hajnoczi wrote: On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: Ever since the introduction of the virtio vsock driver, it included pushback logic that blocks it from taking any new R

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-02 Thread Stefano Garzarella
On Wed, Apr 02, 2025 at 10:26:05AM +0100, Simon Horman wrote: On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: Ever since the introduction of the virtio vsock driver, it included pushback logic that blocks it from taking any new RX packets until the TX queue backlog becomes shallo

[PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-01 Thread Alexander Graf
Ever since the introduction of the virtio vsock driver, it included pushback logic that blocks it from taking any new RX packets until the TX queue backlog becomes shallower than the virtqueue size. This logic works fine when you connect a user space application on the hypervisor with a virtio-vso