Re: [PATCH v2] virtio_console: fix a crash in config_work_handler

2017-01-16 Thread Michael S. Tsirkin
On Mon, Jan 16, 2017 at 03:57:23PM +0530, Amit Shah wrote: > On (Mon) 16 Jan 2017 [10:45:02], G. Campana wrote: > > Using control_work instead of config_work as the 3rd argument to > > container_of results in an invalid portdev pointer. Indeed, the work > > structure is initialized as below: > > >

Re: [PATCH v2] virtio_console: fix a crash in config_work_handler

2017-01-16 Thread Amit Shah
On (Mon) 16 Jan 2017 [10:45:02], G. Campana wrote: > Using control_work instead of config_work as the 3rd argument to > container_of results in an invalid portdev pointer. Indeed, the work > structure is initialized as below: > > INIT_WORK(&portdev->config_work, &config_work_handler); > > It

[PATCH v2] virtio_console: fix a crash in config_work_handler

2017-01-16 Thread G. Campana
Using control_work instead of config_work as the 3rd argument to container_of results in an invalid portdev pointer. Indeed, the work structure is initialized as below: INIT_WORK(&portdev->config_work, &config_work_handler); It leads to a crash when portdev->vdev is dereferenced later. This b