Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM

2015-12-18 Thread Sebastian Frias
On 12/18/2015 05:34 PM, Peter Hurley wrote: On 12/18/2015 08:27 AM, Sebastian Frias wrote: On 12/18/2015 05:06 PM, Peter Hurley wrote: -unsigned char old_dll, old_dlm, old_lcr; +unsigned char old_lcr; unsigned int id; +unsigned int old_dl; unsigned int id, old_dl; Ok

Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM

2015-12-18 Thread Peter Hurley
On 12/18/2015 08:27 AM, Sebastian Frias wrote: > On 12/18/2015 05:06 PM, Peter Hurley wrote: >>> -unsigned char old_dll, old_dlm, old_lcr; >>> +unsigned char old_lcr; >>> unsigned int id; >>> +unsigned int old_dl; >> >> unsigned int id, old_dl; > > Ok, thanks for your comment

Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM

2015-12-18 Thread Sebastian Frias
On 12/18/2015 05:06 PM, Peter Hurley wrote: -unsigned char old_dll, old_dlm, old_lcr; +unsigned char old_lcr; unsigned int id; +unsigned int old_dl; unsigned int id, old_dl; Ok, thanks for your comments. By the way, should I just do: -unsigned char old_dll, old_

Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM

2015-12-18 Thread Peter Hurley
Hi Sebastian, On 12/18/2015 02:46 AM, Sebastian Frias wrote: > --- > > Some UART HW has a single register combining UART_DLL/UART_DLM > (this was probably forgotten in the change that introduced the > callbacks, commit b32b19b8ffc05cbd3bf91c65e205f6a912ca15d9) Thanks for the fix. Because of the

[PATCH v2] use callbacks to access UART_DLL/UART_DLM

2015-12-18 Thread Sebastian Frias
--- Some UART HW has a single register combining UART_DLL/UART_DLM (this was probably forgotten in the change that introduced the callbacks, commit b32b19b8ffc05cbd3bf91c65e205f6a912ca15d9) Fixes: b32b19b8ffc0 Signed-off-by: Sebastian Frias --- drivers/tty/serial/8250/8250_port.c | 17 +