Re: [PATCH v2] tty: serial: qcom_geni_serial: Fix softlock

On Thu, Nov 29, 2018 at 2:12 PM Doug Anderson wrote: > > Hi, > > On Wed, Nov 28, 2018 at 3:55 PM Ryan Case wrote: > > @@ -465,9 +470,19 @@ static void qcom_geni_serial_console_write(struct > > console *co, const char *s, > > } > > writel_relaxed(M_CMD_CANCEL_EN, u

Re: [PATCH v2] tty: serial: qcom_geni_serial: Fix softlock

Hi, On Wed, Nov 28, 2018 at 3:55 PM Ryan Case wrote: > @@ -465,9 +470,19 @@ static void qcom_geni_serial_console_write(struct > console *co, const char *s, > } > writel_relaxed(M_CMD_CANCEL_EN, uport->membase + >

Re: [PATCH v2] tty: serial: qcom_geni_serial: Fix softlock

Hi Ryan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on v4.20-rc4 next-20181129] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-c

[PATCH v2] tty: serial: qcom_geni_serial: Fix softlock

Transfers were being divided into device FIFO sized (64 byte max) operations which would poll for completion within a spin_lock_irqsave / spin_unlock_irqrestore block. This both made things slow by waiting for the FIFO to completely drain before adding further data and would also result in softlock