Re: [PATCH v2] tty: implement led triggers

2018-05-12 Thread Uwe Kleine-König
On Thu, May 10, 2018 at 12:25:21PM +0100, Robin Murphy wrote: > On 10/05/18 12:14, Pavel Machek wrote: > > Hi! > > > > > > > > @@ -499,6 +500,7 @@ static void flush_to_ldisc(struct work_struct > > > > > > *work) > > > > > > struct tty_buffer *head = buf->head; > > > > > >

Re: [PATCH v2] tty: implement led triggers

2018-05-10 Thread Robin Murphy
On 10/05/18 12:14, Pavel Machek wrote: Hi! @@ -499,6 +500,7 @@ static void flush_to_ldisc(struct work_struct *work) struct tty_buffer *head = buf->head; struct tty_buffer *next; int count; + unsigned long delay = 50 /* ms */; Comme

Re: [PATCH v2] tty: implement led triggers

2018-05-10 Thread Pavel Machek
Hi! > > > > @@ -499,6 +500,7 @@ static void flush_to_ldisc(struct work_struct *work) > > > > struct tty_buffer *head = buf->head; > > > > struct tty_buffer *next; > > > > int count; > > > > + unsigned long delay = 50 /* ms */; > > > >

Re: [PATCH v2] tty: implement led triggers

2018-05-07 Thread Johan Hovold
On Mon, May 07, 2018 at 10:41:27AM +0200, Uwe Kleine-König wrote: > Hello Johan, > > thanks for your feedback. > > On Mon, May 07, 2018 at 10:02:52AM +0200, Johan Hovold wrote: > > On Thu, May 03, 2018 at 10:19:52PM +0200, Uwe Kleine-König wrote: > > > The rx trigger fires when data is pushed to

Re: [PATCH v2] tty: implement led triggers

2018-05-07 Thread Uwe Kleine-König
Hello Johan, thanks for your feedback. On Mon, May 07, 2018 at 10:02:52AM +0200, Johan Hovold wrote: > On Thu, May 03, 2018 at 10:19:52PM +0200, Uwe Kleine-König wrote: > > The rx trigger fires when data is pushed to the ldisc. This is a bit later > > than the actual receiving of data but has the

Re: [PATCH v2] tty: implement led triggers

2018-05-07 Thread Johan Hovold
On Thu, May 03, 2018 at 10:19:52PM +0200, Uwe Kleine-König wrote: > The rx trigger fires when data is pushed to the ldisc. This is a bit later > than the actual receiving of data but has the nice benefit that it > doesn't need adaption for each driver and isn't in the hot path. > > Similarily the

Re: [PATCH v2] tty: implement led triggers

2018-05-03 Thread kbuild test robot
Hi Uwe, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on v4.17-rc3 next-20180503] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH v2] tty: implement led triggers

2018-05-03 Thread Uwe Kleine-König
The rx trigger fires when data is pushed to the ldisc. This is a bit later than the actual receiving of data but has the nice benefit that it doesn't need adaption for each driver and isn't in the hot path. Similarily the tx trigger fires when data taken from the ldisc. Signed-off-by: Uwe Kleine-