Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-07-06 Thread Jarkko Sakkinen
On Mon, Jul 06, 2020 at 05:43:35PM +0300, Jarkko Sakkinen wrote: > On Mon, Jul 06, 2020 at 05:00:51PM +0300, Jarkko Sakkinen wrote: > > On Mon, Jul 06, 2020 at 11:46:46AM +, peter.hu...@infineon.com wrote: > > > Hi, > > > NACK > > > > > > > % git --no-pager grep IFX0102 drivers/char/tpm > > >

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-07-06 Thread Jarkko Sakkinen
On Mon, Jul 06, 2020 at 05:00:51PM +0300, Jarkko Sakkinen wrote: > On Mon, Jul 06, 2020 at 11:46:46AM +, peter.hu...@infineon.com wrote: > > Hi, > > NACK > > > > > % git --no-pager grep IFX0102 drivers/char/tpm > > > drivers/char/tpm/tpm_infineon.c: {"IFX0102", 0}, > > > drivers/char/tpm/tpm_

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-07-06 Thread Jarkko Sakkinen
On Mon, Jul 06, 2020 at 11:46:46AM +, peter.hu...@infineon.com wrote: > Hi, > NACK > > > % git --no-pager grep IFX0102 drivers/char/tpm > > drivers/char/tpm/tpm_infineon.c:{"IFX0102", 0}, > > drivers/char/tpm/tpm_tis.c: {"IFX0102", 0}, /* Infineon */ > > Obviously IFX0102 was added

RE: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-07-06 Thread Peter.Huewe
Hi, NACK > % git --no-pager grep IFX0102 drivers/char/tpm > drivers/char/tpm/tpm_infineon.c: {"IFX0102", 0}, > drivers/char/tpm/tpm_tis.c: {"IFX0102", 0}, /* Infineon */ > Obviously IFX0102 was added to the HID table for the TCG TIS driver by > mistake. The HID IFX0102 was NOT add

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-07-02 Thread Jarkko Sakkinen
On Tue, Jun 30, 2020 at 12:15:15PM -0700, Jerry Snitselaar wrote: > On Fri Jun 26 20, Jarkko Sakkinen wrote: > > On Thu, Jun 25, 2020 at 02:19:23PM -0700, Jerry Snitselaar wrote: > > > On Fri Jun 26 20, Jarkko Sakkinen wrote: > > > > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote:

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-07-02 Thread Jarkko Sakkinen
On Fri, Jun 26, 2020 at 07:36:31AM -0700, James Bottomley wrote: > On Fri, 2020-06-26 at 16:15 +0300, Jarkko Sakkinen wrote: > > I have an obstacle with that. > > > > I lost my previous PGP key a year ago and created a new one, which is > > not trusted yet by anyone [*]. I've backed this up now an

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-30 Thread Jerry Snitselaar
On Fri Jun 26 20, Jarkko Sakkinen wrote: On Thu, Jun 25, 2020 at 02:19:23PM -0700, Jerry Snitselaar wrote: On Fri Jun 26 20, Jarkko Sakkinen wrote: > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote: > > On Thu Jun 25 20, Jarkko Sakkinen wrote: > > > Acer C720 running Linux v5.3

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-26 Thread James Bottomley
On Fri, 2020-06-26 at 16:15 +0300, Jarkko Sakkinen wrote: > I have an obstacle with that. > > I lost my previous PGP key a year ago and created a new one, which is > not trusted yet by anyone [*]. I've backed this up now and have it > stored inside Nitrokey Pro 2 in order to prevent this happening

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-26 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 02:23:59PM -0700, James Bottomley wrote: > On Thu, 2020-06-25 at 14:19 -0700, Jerry Snitselaar wrote: > > On Fri Jun 26 20, Jarkko Sakkinen wrote: > > > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote: > > > > On Thu Jun 25 20, Jarkko Sakkinen wrote: > > > >

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-26 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 02:19:23PM -0700, Jerry Snitselaar wrote: > On Fri Jun 26 20, Jarkko Sakkinen wrote: > > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote: > > > On Thu Jun 25 20, Jarkko Sakkinen wrote: > > > > Acer C720 running Linux v5.3 reports this in klog: > > > > > > >

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-25 Thread James Bottomley
On Thu, 2020-06-25 at 14:19 -0700, Jerry Snitselaar wrote: > On Fri Jun 26 20, Jarkko Sakkinen wrote: > > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote: > > > On Thu Jun 25 20, Jarkko Sakkinen wrote: > > > > Acer C720 running Linux v5.3 reports this in klog: > > > > > > > > tpm_

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-25 Thread Jerry Snitselaar
On Fri Jun 26 20, Jarkko Sakkinen wrote: On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote: On Thu Jun 25 20, Jarkko Sakkinen wrote: > Acer C720 running Linux v5.3 reports this in klog: > > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) > tpm tpm0: tpm_try_transmit: send(): error -5

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-25 Thread Jarkko Sakkinen
On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote: > On Thu Jun 25 20, Jarkko Sakkinen wrote: > > Acer C720 running Linux v5.3 reports this in klog: > > > > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) > > tpm tpm0: tpm_try_transmit: send(): error -5 > > tpm tpm0: A TPM error (-5) oc

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-24 Thread Jerry Snitselaar
On Thu Jun 25 20, Jarkko Sakkinen wrote: Acer C720 running Linux v5.3 reports this in klog: tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) tpm tpm0: tpm_try_transmit: send(): error -5 tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts tpm_tis tpm_tis: Could not get TPM timeout

[PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-24 Thread Jarkko Sakkinen
Acer C720 running Linux v5.3 reports this in klog: tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) tpm tpm0: tpm_try_transmit: send(): error -5 tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts tpm_tis tpm_tis: Could not get TPM timeouts and durations tpm_tis 00:08: 1.2 TPM (dev