Re: [PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
Hey Ronnie, On 10/9/18 11:47 PM, Ronnie Sahlberg wrote: > Good catch, but I think it should be : > > int resp_buftype = CIFS_NO_BUFFER; > Oh okay. I'll send v3 shortly. Thanks for the feedback. -- Gustavo

Re: [PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Ronnie Sahlberg
g, "Gustavo A. R. Silva" Sent: Wednesday, 10 October, 2018 6:17:48 AM Subject: [PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which

[PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which it is used in a comparison without being properly initialized previously. Fix this by initializing variable *resp_buftype* to -1 in order to avoid unpredictable or uni