Re: [PATCH v2] serial: max310x: rework RX interrupt handling

2020-10-28 Thread Jan Kundrát
On čtvrtek 1. října 2020 9:44:15 CEST, Thomas Petazzoni wrote: Currently, the RX interrupt logic uses the RXEMPTY interrupt, with the RXEMPTYINV bit set, which means we get an RX interrupt as soon as the RX FIFO is non-empty. However, with the MAX310X having a FIFO of 128 bytes, this makes very

Re: [PATCH v2] serial: max310x: rework RX interrupt handling

2020-10-28 Thread Thomas Petazzoni
Hello, On Wed, 28 Oct 2020 17:20:24 +0100 Jan Kundrát wrote: > Thanks for taking the time to write this patch. We're using MAX14830 on a > Clearfog Base board via a 26 MHz SPI bus. Our code polls a custom > peripheral over UART at 115200 baud ten times a second; the messages are > typically s

Re: [PATCH v2] serial: max310x: rework RX interrupt handling

2020-10-28 Thread Thomas Petazzoni
Hello, On Wed, 28 Oct 2020 18:06:51 +0100 Thomas Petazzoni wrote: > On my way to send a v3 :-) Well, in fact the patch is upstream already: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/tty/serial/max310x.c?id=fce3c5c1a2d9cd888f2987662ce17c0c651916b2 So

Re: [PATCH v2] serial: max310x: rework RX interrupt handling

2020-10-01 Thread Andy Shevchenko
On Thu, Oct 1, 2020 at 10:44 AM Thomas Petazzoni wrote: > > Currently, the RX interrupt logic uses the RXEMPTY interrupt, with the > RXEMPTYINV bit set, which means we get an RX interrupt as soon as the > RX FIFO is non-empty. > > However, with the MAX310X having a FIFO of 128 bytes, this makes ve

[PATCH v2] serial: max310x: rework RX interrupt handling

2020-10-01 Thread Thomas Petazzoni
Currently, the RX interrupt logic uses the RXEMPTY interrupt, with the RXEMPTYINV bit set, which means we get an RX interrupt as soon as the RX FIFO is non-empty. However, with the MAX310X having a FIFO of 128 bytes, this makes very poor use of the FIFO: we trigger an interrupt as soon as the RX F