Re: [PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-15 Thread Waiman Long
On 06/13/2015 03:35 AM, Yury wrote: On 13.06.2015 01:35, Waiman Long wrote: On 06/12/2015 08:31 AM, Stephen Smalley wrote: On 06/12/2015 02:26 AM, Raghavendra K T wrote: On 06/12/2015 03:01 AM, Waiman Long wrote: The inode_free_security() function just took the superblock's isec_lock before

Re: [PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-15 Thread Stephen Smalley
On 06/14/2015 12:01 AM, Raghavendra K T wrote: > On 06/13/2015 04:05 AM, Waiman Long wrote: >> On 06/12/2015 08:31 AM, Stephen Smalley wrote: >>> On 06/12/2015 02:26 AM, Raghavendra K T wrote: On 06/12/2015 03:01 AM, Waiman Long wrote: > The inode_free_security() function just took the sup

Re: [PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-13 Thread Raghavendra K T
On 06/13/2015 04:05 AM, Waiman Long wrote: On 06/12/2015 08:31 AM, Stephen Smalley wrote: On 06/12/2015 02:26 AM, Raghavendra K T wrote: On 06/12/2015 03:01 AM, Waiman Long wrote: The inode_free_security() function just took the superblock's isec_lock before checking and trying to remove the i

Re: [PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-13 Thread Eric Paris
On Sat, 2015-06-13 at 10:35 +0300, Yury wrote: > > On 13.06.2015 01:35, Waiman Long wrote: > > On 06/12/2015 08:31 AM, Stephen Smalley wrote: > > > On 06/12/2015 02:26 AM, Raghavendra K T wrote: > > > > On 06/12/2015 03:01 AM, Waiman Long wrote: > > > > > The inode_free_security() function just to

Re: [PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-13 Thread Yury
On 13.06.2015 01:35, Waiman Long wrote: On 06/12/2015 08:31 AM, Stephen Smalley wrote: On 06/12/2015 02:26 AM, Raghavendra K T wrote: On 06/12/2015 03:01 AM, Waiman Long wrote: The inode_free_security() function just took the superblock's isec_lock before checking and trying to remove the in

Re: [PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-12 Thread Waiman Long
On 06/12/2015 08:31 AM, Stephen Smalley wrote: On 06/12/2015 02:26 AM, Raghavendra K T wrote: On 06/12/2015 03:01 AM, Waiman Long wrote: The inode_free_security() function just took the superblock's isec_lock before checking and trying to remove the inode security struct from the linked list. I

Re: [PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-12 Thread Eric Paris
On Fri, 2015-06-12 at 08:31 -0400, Stephen Smalley wrote: > On 06/12/2015 02:26 AM, Raghavendra K T wrote: > > On 06/12/2015 03:01 AM, Waiman Long wrote: > > > The inode_free_security() function just took the superblock's > > > isec_lock > > > before checking and trying to remove the inode securit

Re: [PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-12 Thread Stephen Smalley
On 06/12/2015 02:26 AM, Raghavendra K T wrote: > On 06/12/2015 03:01 AM, Waiman Long wrote: >> The inode_free_security() function just took the superblock's isec_lock >> before checking and trying to remove the inode security struct from the >> linked list. In many cases, the list was empty and so

Re: [PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-11 Thread Raghavendra K T
On 06/12/2015 03:01 AM, Waiman Long wrote: The inode_free_security() function just took the superblock's isec_lock before checking and trying to remove the inode security struct from the linked list. In many cases, the list was empty and so the lock taking is wasteful as no useful work is done. O

[PATCH v2] selinux: reduce locking overhead in inode_free_security()

2015-06-11 Thread Waiman Long
The inode_free_security() function just took the superblock's isec_lock before checking and trying to remove the inode security struct from the linked list. In many cases, the list was empty and so the lock taking is wasteful as no useful work is done. On multi-socket systems with a large number of