Re: [PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task

2019-03-07 Thread Martin K. Petersen
Lee, > If there is an error queueing an iscsi command in > iscsi_queuecommand(), for example if the transport fails to take the > command in sessuin->tt->xmit_task(), then the error path can call > iscsi_complete_task() without first aquiring the back_lock as > required. This can lead to things

Re: [PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task

2019-03-07 Thread Chris Leech
On Thu, Mar 07, 2019 at 05:37:50PM -0800, Lee Duncan wrote: > On 3/6/19 10:23 AM, Chris Leech wrote: > > On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote: > >> From: Lee Duncan > >> > >> If there is an error queueing an iscsi command in > >> iscsi_queuecommand(), for example if the trans

Re: [PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task

2019-03-07 Thread Lee Duncan
On 3/6/19 10:23 AM, Chris Leech wrote: > On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote: >> From: Lee Duncan >> >> If there is an error queueing an iscsi command in >> iscsi_queuecommand(), for example if the transport fails >> to take the command in sessuin->tt->xmit_task(), then >> t

Re: [PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task

2019-03-06 Thread Chris Leech
On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote: > From: Lee Duncan > > If there is an error queueing an iscsi command in > iscsi_queuecommand(), for example if the transport fails > to take the command in sessuin->tt->xmit_task(), then > the error path can call iscsi_complete_task() w

[PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task

2019-02-25 Thread Lee Duncan
From: Lee Duncan If there is an error queueing an iscsi command in iscsi_queuecommand(), for example if the transport fails to take the command in sessuin->tt->xmit_task(), then the error path can call iscsi_complete_task() without first aquiring the back_lock as required. This can lead to things